From 3c4279bc45227344d884a32bdc794751ee0e46bb Mon Sep 17 00:00:00 2001 From: Ewan Crawford Date: Tue, 1 Jul 2025 18:04:04 +0100 Subject: [PATCH] [BLAS] Skip sycl-graph tests on AMD As reported in https://github.com/uxlfoundation/oneMath/pull/696#issuecomment-3024746970 the sycl-graph blas unit_tests are failing on AMD. Skip these tests until the functionality can be implemented --- tests/unit_tests/blas/sycl-graph/gemm_batch_usm.cpp | 12 +++++++++++- tests/unit_tests/blas/sycl-graph/gemm_usm.cpp | 12 +++++++++++- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/tests/unit_tests/blas/sycl-graph/gemm_batch_usm.cpp b/tests/unit_tests/blas/sycl-graph/gemm_batch_usm.cpp index 807b66dbc..6f97e0603 100644 --- a/tests/unit_tests/blas/sycl-graph/gemm_batch_usm.cpp +++ b/tests/unit_tests/blas/sycl-graph/gemm_batch_usm.cpp @@ -358,8 +358,18 @@ int test(device*, oneapi::math::layout, int64_t, size_t) { struct GraphGemmBatchUsmTests : public ::testing::TestWithParam> { virtual void SetUp() override { + auto device = std::get<0>(GetParam()); + if (device->get_backend() == sycl::backend::opencl) { + GTEST_SKIP() << "Test not yet supported on OpenCL"; + } +#if SYCL_EXT_ONEAPI_BACKEND_HIP + if (device->get_backend() == sycl::backend::ext_oneapi_hip) { + GTEST_SKIP() << "Test not yet supported on HIP"; + } +#endif + // Skip test if graph recording variant and device doesn't support sycl_ext_oneapi_graph - CHECK_GRAPH_ON_DEVICE(std::get<0>(GetParam())); + CHECK_GRAPH_ON_DEVICE(device); } }; diff --git a/tests/unit_tests/blas/sycl-graph/gemm_usm.cpp b/tests/unit_tests/blas/sycl-graph/gemm_usm.cpp index 30591cac7..71f04f1f1 100644 --- a/tests/unit_tests/blas/sycl-graph/gemm_usm.cpp +++ b/tests/unit_tests/blas/sycl-graph/gemm_usm.cpp @@ -173,8 +173,18 @@ int test(device*, oneapi::math::layout, int, int, int, int, int, int, Tc, Tc) { struct GraphGemmUsmTests : public ::testing::TestWithParam> { virtual void SetUp() override { + auto device = std::get<0>(GetParam()); + if (device->get_backend() == sycl::backend::opencl) { + GTEST_SKIP() << "Test not yet supported on OpenCL"; + } +#if SYCL_EXT_ONEAPI_BACKEND_HIP + if (device->get_backend() == sycl::backend::ext_oneapi_hip) { + GTEST_SKIP() << "Test not yet supported on HIP"; + } +#endif + // Skip test if graph recording variant and device doesn't support sycl_ext_oneapi_graph - CHECK_GRAPH_ON_DEVICE(std::get<0>(GetParam())); + CHECK_GRAPH_ON_DEVICE(device); } };