From 7d2a2f9682fab0b1f8f2dfcb9967e3a206da0cb6 Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 7 Nov 2025 16:01:14 -0500 Subject: [PATCH 1/8] Improve debug log in aws_ecs_metrics --- src/internal_events/aws_ecs_metrics.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/internal_events/aws_ecs_metrics.rs b/src/internal_events/aws_ecs_metrics.rs index eba1fa145e0a8..fc9d53b9b986d 100644 --- a/src/internal_events/aws_ecs_metrics.rs +++ b/src/internal_events/aws_ecs_metrics.rs @@ -52,8 +52,9 @@ impl InternalEvent for AwsEcsMetricsParseError<'_> { error_type = error_type::PARSER_FAILED, ); debug!( - message = %format!("Failed to parse response:\\n\\n{}\\n\\n", self.body.escape_debug()), + response = %self.body.escape_debug(), endpoint = %self.endpoint, + "Failed to parse response", ); counter!("parse_errors_total").increment(1); counter!( From 3da79f95d40edb6302f670e8e315aa48705029aa Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 7 Nov 2025 16:06:54 -0500 Subject: [PATCH 2/8] Add internal_log_rate_limit = false to config reload errors --- src/internal_events/config.rs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/internal_events/config.rs b/src/internal_events/config.rs index c8fb994c85c94..7c9e80dc87788 100644 --- a/src/internal_events/config.rs +++ b/src/internal_events/config.rs @@ -14,6 +14,7 @@ impl InternalEvent for ConfigReloadRejected { message = "Config reload rejected due to non-reloadable global options.", reason = %self.reason.as_str(), changed_fields = %fields.join(", "), + internal_log_rate_limit = false, ); counter!( @@ -27,6 +28,7 @@ impl InternalEvent for ConfigReloadRejected { message = "Config reload rejected due to failed to compute global diff.", reason = %self.reason.as_str(), error = %err, + internal_log_rate_limit = false, ); counter!( From 205f491e854b863798aa3b3508982941d8beadc7 Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 7 Nov 2025 16:08:03 -0500 Subject: [PATCH 3/8] Disable rate limiting for lua build failure --- src/internal_events/lua.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/internal_events/lua.rs b/src/internal_events/lua.rs index 9d202112fea5b..1770761fda489 100644 --- a/src/internal_events/lua.rs +++ b/src/internal_events/lua.rs @@ -58,6 +58,7 @@ impl InternalEvent for LuaBuildError { error_type = error_type::SCRIPT_FAILED, error_code = lua_build_error_code(&self.error), stage = error_stage::PROCESSING, + internal_log_rate_limit = false, ); counter!( "component_errors_total", From 2de5be0b157f04159dc409410e87ee8b9c36c1a8 Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 7 Nov 2025 16:08:57 -0500 Subject: [PATCH 4/8] Disable rate limiting for amqp build failure --- src/sinks/amqp/config.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/sinks/amqp/config.rs b/src/sinks/amqp/config.rs index 9e0a2fb273321..8d7442cb37e70 100644 --- a/src/sinks/amqp/config.rs +++ b/src/sinks/amqp/config.rs @@ -45,6 +45,7 @@ impl AmqpPropertiesConfig { error = %error, error_type = error_type::TEMPLATE_FAILED, stage = error_stage::PROCESSING, + internal_log_rate_limit = false, ); Default::default() }); From 790f245e973b47196b8cf037f9a3932cabc0f8a9 Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 7 Nov 2025 16:19:24 -0500 Subject: [PATCH 5/8] Add internal_log_rate_limit = false to important failures during reload --- src/config/watcher.rs | 40 ++++++++++++++++++++++++++++++---------- 1 file changed, 30 insertions(+), 10 deletions(-) diff --git a/src/config/watcher.rs b/src/config/watcher.rs index 5f02b9d4128b3..3f4b42456548c 100644 --- a/src/config/watcher.rs +++ b/src/config/watcher.rs @@ -147,19 +147,39 @@ pub fn spawn_thread<'a>( .all(|(_, t)| *t == ComponentType::EnrichmentTable) { info!("Only enrichment tables have changed."); - _ = signal_tx.send(crate::signal::SignalTo::ReloadEnrichmentTables).map_err(|error| { - error!(message = "Unable to reload enrichment tables.", cause = %error) - }); + _ = signal_tx + .send(crate::signal::SignalTo::ReloadEnrichmentTables) + .map_err(|error| { + true; + error!( + message = "Unable to reload enrichment tables.", + cause = %error, + internal_log_rate_limit = false, + ) + }); } else { - _ = signal_tx.send(crate::signal::SignalTo::ReloadComponents(changed_components.into_keys().collect())).map_err(|error| { - error!(message = "Unable to reload component configuration. Restart Vector to reload it.", cause = %error) - }); + _ = signal_tx + .send(crate::signal::SignalTo::ReloadComponents( + changed_components.into_keys().collect(), + )) + .map_err(|error| { + error!( + message = "Unable to reload component configuration. Restart Vector to reload it.", + cause = %error, + internal_log_rate_limit = false, + ) + }); } } else { - _ = signal_tx.send(crate::signal::SignalTo::ReloadFromDisk) - .map_err(|error| { - error!(message = "Unable to reload configuration file. Restart Vector to reload it.", cause = %error) - }); + _ = signal_tx + .send(crate::signal::SignalTo::ReloadFromDisk) + .map_err(|error| { + error!( + message = "Unable to reload configuration file. Restart Vector to reload it.", + cause = %error, + internal_log_rate_limit = false, + ) + }); } } else { debug!(message = "Ignoring event.", event = ?event) From 088fe2e0e675b75fe47941d81e344adfd56da786 Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 7 Nov 2025 16:27:59 -0500 Subject: [PATCH 6/8] Disable log rate limit for repeated events in process.rs --- src/internal_events/process.rs | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/internal_events/process.rs b/src/internal_events/process.rs index 3d5f3100e6f9d..ce8fbd063f438 100644 --- a/src/internal_events/process.rs +++ b/src/internal_events/process.rs @@ -30,7 +30,8 @@ impl InternalEvent for VectorReloaded<'_> { info!( target: "vector", message = "Vector has reloaded.", - path = ?self.config_paths + path = ?self.config_paths, + internal_log_rate_limit = false, ); counter!("reloaded_total").increment(1); } @@ -43,7 +44,7 @@ impl InternalEvent for VectorStopped { fn emit(self) { info!( target: "vector", - message = "Vector has stopped." + message = "Vector has stopped.", ); counter!("stopped_total").increment(1); } @@ -56,7 +57,7 @@ impl InternalEvent for VectorQuit { fn emit(self) { info!( target: "vector", - message = "Vector has quit." + message = "Vector has quit.", ); counter!("quit_total").increment(1); } @@ -72,6 +73,7 @@ impl InternalEvent for VectorReloadError { error_code = "reload", error_type = error_type::CONFIGURATION_FAILED, stage = error_stage::PROCESSING, + internal_log_rate_limit = false, ); counter!( "component_errors_total", @@ -93,6 +95,7 @@ impl InternalEvent for VectorConfigLoadError { error_code = "config_load", error_type = error_type::CONFIGURATION_FAILED, stage = error_stage::PROCESSING, + internal_log_rate_limit = false, ); counter!( "component_errors_total", @@ -114,6 +117,7 @@ impl InternalEvent for VectorRecoveryError { error_code = "recovery", error_type = error_type::CONFIGURATION_FAILED, stage = error_stage::PROCESSING, + internal_log_rate_limit = false, ); counter!( "component_errors_total", From 1e6d53f23b8866b8240573d1fdd233004654468a Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 7 Nov 2025 16:35:27 -0500 Subject: [PATCH 7/8] Update src/config/watcher.rs --- src/config/watcher.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/config/watcher.rs b/src/config/watcher.rs index 3f4b42456548c..1a4bc2f0cc734 100644 --- a/src/config/watcher.rs +++ b/src/config/watcher.rs @@ -150,7 +150,6 @@ pub fn spawn_thread<'a>( _ = signal_tx .send(crate::signal::SignalTo::ReloadEnrichmentTables) .map_err(|error| { - true; error!( message = "Unable to reload enrichment tables.", cause = %error, From 4a7de75b21c712c39607f910a7cff34626d2d9bd Mon Sep 17 00:00:00 2001 From: Thomas Date: Mon, 10 Nov 2025 09:56:58 -0500 Subject: [PATCH 8/8] Fix message format --- src/internal_events/aws_ecs_metrics.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/internal_events/aws_ecs_metrics.rs b/src/internal_events/aws_ecs_metrics.rs index fc9d53b9b986d..4589a3eda70d2 100644 --- a/src/internal_events/aws_ecs_metrics.rs +++ b/src/internal_events/aws_ecs_metrics.rs @@ -54,7 +54,7 @@ impl InternalEvent for AwsEcsMetricsParseError<'_> { debug!( response = %self.body.escape_debug(), endpoint = %self.endpoint, - "Failed to parse response", + "Failed to parse response.", ); counter!("parse_errors_total").increment(1); counter!(