Skip to content

Revert ncc webpack#7370

Merged
timneutkens merged 2 commits into
vercel:canaryfrom
timneutkens:add/revert-ncc-webpack
May 17, 2019
Merged

Revert ncc webpack#7370
timneutkens merged 2 commits into
vercel:canaryfrom
timneutkens:add/revert-ncc-webpack

Conversation

@timneutkens
Copy link
Copy Markdown
Contributor

@timneutkens timneutkens commented May 17, 2019

Fixes #7369

Reopens #6240

It works with next build but in next dev it breaks currently.

@github-actions
Copy link
Copy Markdown
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary timneutkens/next.js add/revert-ncc-webpack Change
Build Duration 13.5s 13.9s ⚠️ +333ms
node_modules Size 38.9 MB 40 MB ⚠️ +1.06 MB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB
Client _app Size 2.54 kB 2.54 kB
Client _app gzip Size 1.05 kB 1.05 kB
Client _error Size 8.19 kB 8.19 kB
Client _error gzip Size 3.11 kB 3.12 kB ⚠️ +1 B
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.83 kB 4.83 kB
Client pages/link gzip Size 2.11 kB 2.11 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.63 kB 7.63 kB ⚠️ +1 B
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB -1 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Base Rendered Size 1.34 kB 1.34 kB
Build Dir Size 801 kB 801 kB
Click to expand serverless stats
zeit/next.js canary timneutkens/next.js add/revert-ncc-webpack Change
Build Duration 15.5s 15.1s -380ms
node_modules Size 38.9 MB 40 MB ⚠️ +1.06 MB
Total Bundle (main, webpack, commons) Size 209 kB 209 kB
Total Bundle (main, webpack, commons) gzip Size 68.3 kB 68.3 kB
Client _app Size 2.54 kB 2.54 kB
Client _app gzip Size 1.05 kB 1.05 kB
Client _error Size 8.19 kB 8.19 kB
Client _error gzip Size 3.12 kB 3.12 kB
Client pages/index Size 288 B 288 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.83 kB 4.83 kB
Client pages/link gzip Size 2.11 kB 2.11 kB
Client pages/routerDirect Size 411 B 411 B
Client pages/routerDirect gzip Size 296 B 296 B
Client pages/withRouter Size 393 B 393 B
Client pages/withRouter gzip Size 280 B 280 B
Client main Size 23.3 kB 23.3 kB
Client main gzip Size 7.63 kB 7.63 kB ⚠️ +1 B
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.4 kB 59.4 kB -1 B
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 769 B 769 B
Serverless pages/link Size 342 kB 342 kB -2 B
Serverless pages/link gzip Size 88.7 kB 88.7 kB ⚠️ +3 B
Serverless pages/index Size 333 kB 333 kB -2 B
Serverless pages/index gzip Size 86.3 kB 86.3 kB -1 B
Serverless pages/_error Size 334 kB 334 kB -2 B
Serverless pages/_error gzip Size 86.1 kB 86.1 kB ⚠️ +2 B
Serverless pages/routerDirect Size 333 kB 333 kB -2 B
Serverless pages/routerDirect gzip Size 86.3 kB 86.3 kB ⚠️ +1 B
Serverless pages/withRouter Size 333 kB 333 kB -2 B
Serverless pages/withRouter gzip Size 86.4 kB 86.4 kB ⚠️ +2 B
Build Dir Size 2.37 MB 2.37 MB -10 B

@timneutkens timneutkens merged commit 6feca31 into vercel:canary May 17, 2019
@timneutkens timneutkens deleted the add/revert-ncc-webpack branch May 17, 2019 11:25
@lock lock Bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error: Cannot find module 'webpack'

1 participant