fix: ensure consistent CSS ordering between dev and build with Turbopack #86775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Member
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
Fixes vercel#86704 The issue was that CSS files were collected from webpack entrypoints without sorting, leading to non-deterministic ordering between development (next dev --turbopack) and production (next build --turbopack). This commit adds .sort() to the CSS files array in flight-manifest-plugin.ts to ensure consistent alphabetical ordering in both modes. The fix ensures that CSS prioritization is deterministic and matches between dev and build, preventing layout breakage in production.
harshcoder-harsh
force-pushed
the
fix-css-prioritization-issue-86704
branch
from
8637bf4 to
6ab4f8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86704
Problem
CSS prioritization differs between
next dev --turbopackandnext build --turbopack, causing layout breakage in production builds. Styles that load correctly in development mode are applied in a different order in production, breaking the visual appearance.Root Cause
In
flight-manifest-plugin.ts:297-318, CSS files are collected from webpack entrypoints using: