Commit c99b00f
committed
Fix critical end-user journey gaps surfaced in v0.2 audit
Four gaps caught by the end-to-end audit against this repo, the
playground, and the prior agentfolio trial-memory notes:
1. Add 'workflow' scope preflight to both install skills. Default
'gh auth login' lacks the workflow scope, so the user's first
'git push' of a .lock.yml fails with "refusing to allow an
OAuth App to create or update workflow without 'workflow' scope".
Agentfolio memory flagged this gotcha; the plugin never checked
for it until now. Fix: 'gh auth refresh -s workflow -h github.com'.
2. Stale "Every push to main" claim on update-docs in README.md and
CONTRIBUTING.md. update-docs switched to 'schedule: daily' in
d4295cf earlier today. Also cleaned up a stale pr-nitpick-reviewer
reference in CONTRIBUTING (we removed it from dogfooding in b3f6341).
3. Strengthen the 'claude setup-token' TTY warning in auth.md. The
command opens a browser auth flow and silently hangs in headless
containers, SSH without forwarding, and the Claude Code REPL
itself. New note: run it on a local laptop, paste the token into
'gh secret set' (which doesn't need a browser) elsewhere.
4. Fix reviewer-agent pipeline-summary run-id lookup. Instruction
said 'gh run list --workflow=<name>.yml' but the actual files
are <name>.lock.yml. Switched to --workflow="<Display Name>"
form, which is more stable (file names could change; display
names are human-authored).
Caught before the audit caused a real user to trip, but flagging:
(2) and (3) directly, (1) inherited from the author's own past
agentfolio session (the dev environment's privileged setup masked
it from the dogfood), (4) degraded silently in dogfood #6 without
anyone noticing.1 parent cb66d12 commit c99b00f
6 files changed
Lines changed: 23 additions & 6 deletions
File tree
- catalog/agent-team
- skills
- install-agent-team
- install-workflow
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
102 | | - | |
| 101 | + | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
99 | 99 | | |
100 | 100 | | |
101 | 101 | | |
102 | | - | |
| 102 | + | |
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
146 | 154 | | |
147 | 155 | | |
148 | 156 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
34 | 35 | | |
35 | 36 | | |
36 | 37 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
13 | | - | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
14 | 20 | | |
15 | 21 | | |
16 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | 28 | | |
| 29 | + | |
| 30 | + | |
29 | 31 | | |
30 | 32 | | |
31 | 33 | | |
| |||
0 commit comments