From d6325d3cd5c6a1feffc70059c6cf004527a17c14 Mon Sep 17 00:00:00 2001
From: csr632 <632882184@qq.com>
Date: Tue, 26 May 2020 16:11:02 +0800
Subject: [PATCH 1/2] fix: ora swallow rollup warning

---
 src/node/build/index.ts  | 15 +++++++++++++--
 src/node/depOptimizer.ts |  2 +-
 2 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/src/node/build/index.ts b/src/node/build/index.ts
index 192b4101136149..0d8c4add02c603 100644
--- a/src/node/build/index.ts
+++ b/src/node/build/index.ts
@@ -45,9 +45,20 @@ const writeColors = {
 
 const warningIgnoreList = [`CIRCULAR_DEPENDENCY`, `THIS_IS_UNDEFINED`]
 
-export const onRollupWarning: InputOptions['onwarn'] = (warning, warn) => {
+export const onRollupWarning: (
+  spinner: Ora | undefined
+) => InputOptions['onwarn'] = (spinner) => (warning, warn) => {
+  debugger
   if (!warningIgnoreList.includes(warning.code!)) {
+    // ora would swallow the console.warn if we let it keep running
+    // https://github.com/sindresorhus/ora/issues/90
+    if (spinner) {
+      spinner.stop()
+    }
     warn(warning)
+    if (spinner) {
+      spinner.start()
+    }
   }
 }
 
@@ -220,7 +231,7 @@ export async function build(options: BuildConfig): Promise<BuildResult> {
     input: path.resolve(root, 'index.html'),
     preserveEntrySignatures: false,
     treeshake: { moduleSideEffects: 'no-external' },
-    onwarn: onRollupWarning,
+    onwarn: onRollupWarning(spinner),
     ...rollupInputOptions,
     plugins: [
       ...basePlugins,
diff --git a/src/node/depOptimizer.ts b/src/node/depOptimizer.ts
index b942ed27dde0a5..ab4b72d19f2941 100644
--- a/src/node/depOptimizer.ts
+++ b/src/node/depOptimizer.ts
@@ -223,7 +223,7 @@ export async function optimizeDeps(
       input,
       external: preservedDeps,
       treeshake: { moduleSideEffects: 'no-external' },
-      onwarn: onRollupWarning,
+      onwarn: onRollupWarning(spinner),
       ...config.rollupInputOptions,
       plugins: [
         ...(await createBaseRollupPlugins(root, resolver, config)),

From d7de050b996468a64fc279da60c61655aafb959e Mon Sep 17 00:00:00 2001
From: Evan You <yyx990803@gmail.com>
Date: Tue, 26 May 2020 10:12:12 -0400
Subject: [PATCH 2/2] Update index.ts

---
 src/node/build/index.ts | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/node/build/index.ts b/src/node/build/index.ts
index 0d8c4add02c603..7e9dd6c53324a9 100644
--- a/src/node/build/index.ts
+++ b/src/node/build/index.ts
@@ -48,7 +48,6 @@ const warningIgnoreList = [`CIRCULAR_DEPENDENCY`, `THIS_IS_UNDEFINED`]
 export const onRollupWarning: (
   spinner: Ora | undefined
 ) => InputOptions['onwarn'] = (spinner) => (warning, warn) => {
-  debugger
   if (!warningIgnoreList.includes(warning.code!)) {
     // ora would swallow the console.warn if we let it keep running
     // https://github.com/sindresorhus/ora/issues/90