From 6728bfec3681aa5e8cc21913d6062175fb2b4ae6 Mon Sep 17 00:00:00 2001 From: likui <2218301630@qq.com> Date: Sun, 5 Jul 2020 20:10:00 +0800 Subject: [PATCH 1/2] fix(build): link href used data url fix #508 --- src/node/build/buildPluginHtml.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/node/build/buildPluginHtml.ts b/src/node/build/buildPluginHtml.ts index e67f27cc866975..bc064b1321238c 100644 --- a/src/node/build/buildPluginHtml.ts +++ b/src/node/build/buildPluginHtml.ts @@ -1,7 +1,7 @@ import { Plugin, RollupOutput, OutputChunk } from 'rollup' import path from 'path' import fs from 'fs-extra' -import { isExternalUrl, cleanUrl } from '../utils/pathUtils' +import { isExternalUrl, cleanUrl, isDataUrl } from '../utils/pathUtils' import { resolveAsset, registerAssets } from './buildPluginAsset' import { parse as Parse, @@ -189,7 +189,8 @@ const compileHtml = async ( p.type === NodeTypes.ATTRIBUTE && p.value && assetAttrs.includes(p.name) && - !isExternalUrl(p.value.content) + !isExternalUrl(p.value.content) && + !isDataUrl(p.value.content) ) { assetUrls.push(p) } From f880d0f187b7a325965e9dffa38af7b94af0cb40 Mon Sep 17 00:00:00 2001 From: likui <2218301630@qq.com> Date: Sun, 5 Jul 2020 20:10:44 +0800 Subject: [PATCH 2/2] chore: add miss file --- src/node/utils/pathUtils.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/node/utils/pathUtils.ts b/src/node/utils/pathUtils.ts index 92f91284a6acab..c705ec5f1f7dc4 100644 --- a/src/node/utils/pathUtils.ts +++ b/src/node/utils/pathUtils.ts @@ -45,6 +45,9 @@ export const parseWithQuery = ( const externalRE = /^(https?:)?\/\// export const isExternalUrl = (url: string) => externalRE.test(url) +const dataUrlRE = /^\s*data:/i +export const isDataUrl = (url: string) => dataUrlRE.test(url) + const imageRE = /\.(png|jpe?g|gif|svg|ico|webp)(\?.*)?$/ const mediaRE = /\.(mp4|webm|ogg|mp3|wav|flac|aac)(\?.*)?$/ const fontsRE = /\.(woff2?|eot|ttf|otf)(\?.*)?$/i