Add proto messages for remote DiffStateModel#10428
Merged
Merged
Conversation
MaggieShan
force-pushed
the
maggs/diffstatemodel-protos
branch
2 times, most recently
from
d25da75 to
4bf4c75
Compare
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Overview
This PR adds the remote DiffStateModel protocol schema and a tech spec, plus temporary server dispatch arms for the new client messages.
Concerns
- The new request/response messages are currently dropped in
ServerModel, which will leave clients waiting until request timeout if they sendGetDiffStateorDiscardFiles. - The tech spec's field-number summary is out of sync with the proto additions for the discard RPC.
Verdict
Found: 0 critical, 1 important, 1 suggestions
Request changes
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
MaggieShan
force-pushed
the
maggs/diffstatemodel-protos
branch
3 times, most recently
from
a0dbcbd to
13d5401
Compare
1 task
kevinyang372
approved these changes
May 8, 2026
|
|
||
| pub struct GlobalDiffStateModel { | ||
| states: HashMap<ServerDiffStateKey, ModelHandle<LocalDiffStateModel>>, | ||
| per_connection_keys: HashMap<ConnectionId, HashSet<ServerDiffStateKey>>, |
Member
There was a problem hiding this comment.
What is the per_connection_keys used for? If it's for garbage collection, it's shape is better with HashMap<ServerDiffStateKey, HashSet> yeah?
Contributor
Author
There was a problem hiding this comment.
Ack realized I haven't updated the tech spec since implementing - I believe the GlobalDiffStateModel should store maps both ways where:
connection -> keysis used to remove a connection's subscriptions on connection dropkey -> connectionsis used to fan out repo events to its subscribers
MaggieShan
force-pushed
the
maggs/diffstatemodel-protos
branch
from
d72a06a to
faad40b
Compare
3 tasks
MaggieShan
force-pushed
the
maggs/diffstatemodel-protos
branch
from
faad40b to
527e04a
Compare
MaggieShan
force-pushed
the
maggs/diffstatemodel-protos
branch
from
527e04a to
672bfdb
Compare
cephalonaut
pushed a commit
that referenced
this pull request
May 12, 2026
## Description * Adds tech spec for how to support `DiffStateModel` and git states over the remote server / on a remote environment * Adds relevant proto messages ## Linked Issue [APP-4354](https://linear.app/warpdotdev/issue/APP-4354/proto-messages-for-the-diffstatemodel) ## Testing No-op ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode Relevant plan: https://staging.warp.dev/drive/notebook/Remote-DiffStateModel-Proto-Messages-Server-side-Global-Model-and-Client-Wrapper-wqMeKuOHZxWPnTNZiQqbAf
MaggieShan
added a commit
that referenced
this pull request
May 12, 2026
## Description * Built on #10428 * Adds the server-side changes to support `DiffStateModel` and git states on remote environments * Adds type conversions * Adds a `GlobalDiffStateModel` to track each `LocalDiffStateModel` per `repo_path`, `diff_mode` * Adds subscription to repositories to send server messages * Adds handlers for client messages ## Linked Issue [APP-4355](https://linear.app/warpdotdev/issue/APP-4355/hook-up-diffstatemodel-to-remote-server) ## Testing No-op ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
cephalonaut
pushed a commit
that referenced
this pull request
May 12, 2026
## Description * Adds tech spec for how to support `DiffStateModel` and git states over the remote server / on a remote environment * Adds relevant proto messages ## Linked Issue [APP-4354](https://linear.app/warpdotdev/issue/APP-4354/proto-messages-for-the-diffstatemodel) ## Testing No-op ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode Relevant plan: https://staging.warp.dev/drive/notebook/Remote-DiffStateModel-Proto-Messages-Server-side-Global-Model-and-Client-Wrapper-wqMeKuOHZxWPnTNZiQqbAf
cephalonaut
pushed a commit
that referenced
this pull request
May 12, 2026
## Description * Built on #10428 * Adds the server-side changes to support `DiffStateModel` and git states on remote environments * Adds type conversions * Adds a `GlobalDiffStateModel` to track each `LocalDiffStateModel` per `repo_path`, `diff_mode` * Adds subscription to repositories to send server messages * Adds handlers for client messages ## Linked Issue [APP-4355](https://linear.app/warpdotdev/issue/APP-4355/hook-up-diffstatemodel-to-remote-server) ## Testing No-op ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
dagmfactory
pushed a commit
that referenced
this pull request
May 12, 2026
## Description * Built on #10428 * Adds the server-side changes to support `DiffStateModel` and git states on remote environments * Adds type conversions * Adds a `GlobalDiffStateModel` to track each `LocalDiffStateModel` per `repo_path`, `diff_mode` * Adds subscription to repositories to send server messages * Adds handlers for client messages ## Linked Issue [APP-4355](https://linear.app/warpdotdev/issue/APP-4355/hook-up-diffstatemodel-to-remote-server) ## Testing No-op ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
stupidloud
pushed a commit
to stupidloud/warp-cn
that referenced
this pull request
May 21, 2026
## Description * Built on warpdotdev/warp#10428 * Adds the server-side changes to support `DiffStateModel` and git states on remote environments * Adds type conversions * Adds a `GlobalDiffStateModel` to track each `LocalDiffStateModel` per `repo_path`, `diff_mode` * Adds subscription to repositories to send server messages * Adds handlers for client messages ## Linked Issue [APP-4355](https://linear.app/warpdotdev/issue/APP-4355/hook-up-diffstatemodel-to-remote-server) ## Testing No-op ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
lawsmd
pushed a commit
to lawsmd/cortex
that referenced
this pull request
May 22, 2026
## Description * Adds tech spec for how to support `DiffStateModel` and git states over the remote server / on a remote environment * Adds relevant proto messages ## Linked Issue [APP-4354](https://linear.app/warpdotdev/issue/APP-4354/proto-messages-for-the-diffstatemodel) ## Testing No-op ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode Relevant plan: https://staging.warp.dev/drive/notebook/Remote-DiffStateModel-Proto-Messages-Server-side-Global-Model-and-Client-Wrapper-wqMeKuOHZxWPnTNZiQqbAf
lawsmd
pushed a commit
to lawsmd/cortex
that referenced
this pull request
May 22, 2026
## Description * Built on warpdotdev#10428 * Adds the server-side changes to support `DiffStateModel` and git states on remote environments * Adds type conversions * Adds a `GlobalDiffStateModel` to track each `LocalDiffStateModel` per `repo_path`, `diff_mode` * Adds subscription to repositories to send server messages * Adds handlers for client messages ## Linked Issue [APP-4355](https://linear.app/warpdotdev/issue/APP-4355/hook-up-diffstatemodel-to-remote-server) ## Testing No-op ## Agent Mode - [x] Warp Agent Mode - This PR was created via Warp's AI Agent Mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DiffStateModeland git states over the remote server / on a remote environmentLinked Issue
APP-4354
Testing
No-op
Agent Mode
Relevant plan: https://staging.warp.dev/drive/notebook/Remote-DiffStateModel-Proto-Messages-Server-side-Global-Model-and-Client-Wrapper-wqMeKuOHZxWPnTNZiQqbAf