Skip to content

Commit e93338c

Browse files
joannatkustinov
andauthored
Fix error when python 3.12 tests skips (#117)
Co-authored-by: Artem Ustinov <ustinov@users.noreply.github.com>
1 parent 9156941 commit e93338c

File tree

19 files changed

+31
-29
lines changed

19 files changed

+31
-29
lines changed

.github/actions/lint_n_test/action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ runs:
1414
using: composite
1515
steps:
1616
- name: Set up Python ${{ inputs.python_version }}
17-
uses: actions/setup-python@v4
17+
uses: actions/setup-python@v5
1818
with:
1919
python-version: ${{ inputs.python_version }}
2020
check-latest: true
@@ -40,7 +40,7 @@ runs:
4040
run: python -m pydocstyle
4141
shell: bash
4242
- name: Execute Unit Tests
43-
run: python -m unittest discover
43+
run: python -m unittest discover -s ./test*
4444
shell: bash
4545
- name: Check Version Updated in setup.py Before Merging
4646
if: ${{ github.event_name == 'pull_request' }}

.github/workflows/main.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ jobs:
3030
# TODO: Enable Windows and macos
3131
# https://jira.eng.vmware.com/browse/MONIT-30833
3232
os: [ubuntu-latest] # , macos-latest, windows-latest]
33-
python_version: ['3.8', '3.9', '3.10', '3.11']
33+
python_version: ['3.10', '3.11', '3.12', '3.13']
3434
runs-on: ${{ matrix.os }}
3535
steps:
36-
- uses: actions/checkout@v3
36+
- uses: actions/checkout@v4
3737
with:
3838
fetch-depth: 0
3939
- uses: wavefrontHQ/wavefront-sdk-python/.github/actions/lint_n_test@master

.github/workflows/on_merge.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
PKG_REQS: ${{ inputs.requirements || needs.env0.outputs.requirements }}
2525
runs-on: ubuntu-latest
2626
steps:
27-
- uses: actions/checkout@v3
27+
- uses: actions/checkout@v4
2828
with:
2929
fetch-depth: 0
3030
- uses: wavefrontHQ/wavefront-sdk-python/.github/actions/lint_n_test@master

.github/workflows/on_release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ jobs:
2424
PKG_REQS: ${{ inputs.requirements || needs.env0.outputs.requirements }}
2525
runs-on: ubuntu-latest
2626
steps:
27-
- uses: actions/checkout@v3
27+
- uses: actions/checkout@v4
2828
with:
2929
fetch-depth: 0
3030
- uses: wavefrontHQ/wavefront-sdk-python/.github/actions/lint_n_test@master

setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111

1212
setuptools.setup(
1313
name='wavefront-sdk-python',
14-
version='2.1.0', # Please update with each pull request.
14+
version='2.1.1', # Please update with each pull request.
1515
author='VMware Aria Operations for Applications Team',
1616
url='https://github.com/wavefrontHQ/wavefront-sdk-python',
1717
license='Apache-2.0',

wavefront_sdk/client.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ class WavefrontClient(connection_handler.ConnectionHandler,
5656
def __init__(self, server, token, max_queue_size=50000, batch_size=10000,
5757
flush_interval_seconds=5, enable_internal_metrics=True,
5858
queue_impl=queue.Queue):
59-
# pylint: disable=too-many-arguments,too-many-statements
59+
# pylint: disable=too-many-arguments,too-many-positional-arguments
60+
# pylint: disable=too-many-statements
6061
"""Construct Direct Client.
6162
6263
@param server: Server address,
@@ -335,7 +336,7 @@ def close(self):
335336
self._sdk_metrics_registry.close(timeout_secs=1)
336337

337338
def send_metric(self, name, value, timestamp, source, tags):
338-
# pylint: disable=too-many-arguments
339+
# pylint: disable=too-many-arguments,too-many-positional-arguments
339340
"""Send Metric Data via proxy/direct ingestion client.
340341
341342
Wavefront Metrics Data format
@@ -382,7 +383,7 @@ def send_metric_now(self, metrics):
382383

383384
def send_distribution(self, name, centroids, histogram_granularities,
384385
timestamp, source, tags):
385-
# pylint: disable=too-many-arguments
386+
# pylint: disable=too-many-arguments,too-many-positional-arguments
386387
"""Send Distribution Data via proxy/direct ingestion client.
387388
388389
Wavefront Histogram Data format
@@ -433,7 +434,7 @@ def send_distribution_now(self, distributions):
433434

434435
def send_span(self, name, start_millis, duration_millis, source, trace_id,
435436
span_id, parents, follows_from, tags, span_logs):
436-
# pylint: disable=too-many-arguments
437+
# pylint: disable=too-many-arguments,too-many-positional-arguments
437438
"""Send span data via proxy/direct ingestion client.
438439
439440
Wavefront Tracing Span Data format
@@ -521,7 +522,7 @@ def send_span_log_now(self, span_logs):
521522

522523
def send_event(self, name, start_time, end_time, source, tags,
523524
annotations):
524-
# pylint: disable=too-many-arguments
525+
# pylint: disable=too-many-arguments,too-many-positional-arguments
525526
"""Send Event Data via proxy/direct ingestion client.
526527
527528
Wavefront Event Data format

wavefront_sdk/client_factory.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,8 @@ def __init__(self):
3131
"""Keep track of initialized clients on instance level."""
3232
self.clients = []
3333

34-
# pylint: disable=too-many-arguments,too-many-locals
34+
# pylint: disable=too-many-arguments,too-many-positional-arguments
35+
# pylint: disable=too-many-locals
3536
def add_client(self, url, max_queue_size=50000, batch_size=10000,
3637
flush_interval_seconds=5, enable_internal_metrics=True,
3738
queue_impl=queue.Queue,

wavefront_sdk/common/application_tags.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
class ApplicationTags(object):
1717
"""Metadata about your application represented as tags in Wavefront."""
1818

19-
# pylint: disable=too-many-arguments
19+
# pylint: disable=too-many-arguments,too-many-positional-arguments
2020
def __init__(self, application, service, cluster=None, shard=None,
2121
custom_tags=None):
2222
"""Construct ApplicationTags.

wavefront_sdk/common/heartbeater_service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
class HeartbeaterService(object):
2525
"""Service that periodically reports component heartbeats to Wavefront."""
2626

27-
# pylint: disable=too-many-arguments
27+
# pylint: disable=too-many-arguments,too-many-positional-arguments
2828
def __init__(self, wavefront_client, application_tags, components, source):
2929
"""Construct HeartbeaterService.
3030

wavefront_sdk/common/metrics/registry.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
class WavefrontSdkMetricsRegistry(object):
1616
"""Wavefront SDK Metrics Registry."""
1717

18-
# pylint: disable=too-many-arguments
18+
# pylint: disable=too-many-arguments,too-many-positional-arguments
1919
def __init__(self, wf_metric_sender, source=None, tags=None, prefix=None,
2020
reporting_interval_secs=60):
2121
"""Construct Wavefront SDK Metrics Registry."""

0 commit comments

Comments
 (0)