Feature/deploying osmt resources with terraform#335
Closed
Feature/deploying osmt resources with terraform#335
Conversation
JohnKallies
reviewed
Mar 16, 2023
wgu-edwin
requested review from
a team and
JohnKallies
and removed request for
a team
JohnKallies
reviewed
Mar 22, 2023
JohnKallies
reviewed
Mar 22, 2023
JohnKallies
reviewed
Mar 22, 2023
JohnKallies
reviewed
Mar 22, 2023
JohnKallies
reviewed
Mar 22, 2023
JohnKallies
reviewed
Mar 22, 2023
JohnKallies
reviewed
Mar 22, 2023
updated terraform config so it uses correct user profile and credentials removed the vpc, subnet, gateway and routing table resource and just injected the data source for vpc and subnet.
Added some conventional data removed the nginx EC2 as we will have the image running in ECS
Rebasing, fixed merge conflicts Fixed merge conflicts with test sql file
It explains a little bit about what we are trying to accomplish with it and what resources we need and lastly what variables to pass
…n the sql file Now it should be identical with develop fixed merge conflicts with sql file
also updated some code in the user data bash script of the EC2 base on updates i read on AWS docs
updated ECS cluster to add capacity cluster to include fargate for serverless
* set variables for the tags and stack names * Removed hard returns from README.md
wgu-edwin
force-pushed
the
feature/deploying-osmt-resources-with-terraform
branch
from
e83969a to
a9b4109
Compare
Contributor
|
Closing as this is largely addressed by #395 (although only for AWS). Reopen if required in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closed the previous PR because of bad naming convention and bad rebase issue that cause to push unwanted code. It was easier to just create a new PR and closed the previous one