feat: Add EnsureDownloaded fluent method#121
Draft
srebrek wants to merge 2 commits intotests/fix-integration-testsfrom
Draft
feat: Add EnsureDownloaded fluent method#121srebrek wants to merge 2 commits intotests/fix-integration-testsfrom
srebrek wants to merge 2 commits intotests/fix-integration-testsfrom
Conversation
srebrek
force-pushed
the
tests/fix-integration-tests
branch
from
200ba82 to
54a3aed
Compare
srebrek
force-pushed
the
feat/115-ensure-downloaded
branch
from
47c7f53 to
c85e444
Compare
Fixes #115 - add EnsureDownloaded method
srebrek
force-pushed
the
feat/115-ensure-downloaded
branch
from
c85e444 to
987a2dc
Compare
| if (model is LocalModel) | ||
| { | ||
| await AIHub.Model().EnsureDownloadedAsync(_agent.Model); | ||
| } |
Contributor
There was a problem hiding this comment.
I would add some logging/exception when its cloud model - so user is notified that we are not going to download anything and this method should not be used for non-local context. Probably its even better to throw exception (but one of our internal exceptions / new one)
same should be applied for chat context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #115
feat: Add EnsureDownloaded fluent method
!!! Review PR #120 before !!!