Skip to content

Add cross-reference link in Image component docs to UI framework usage#10101

Closed
colemilne54 wants to merge 1 commit into
withastro:mainfrom
colemilne54:main
Closed

Add cross-reference link in Image component docs to UI framework usage#10101
colemilne54 wants to merge 1 commit into
withastro:mainfrom
colemilne54:main

Conversation

@colemilne54
Copy link
Copy Markdown
Contributor

Description

This PR adds a helpful navigation link in the Image component documentation that points readers to the section about passing Astro image components as children to UI framework components. This small enhancement helps users more easily discover the proper way to use Image components within UI frameworks.

@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 24, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 2b4e945
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67438298e83ec70008276f2e
😎 Deploy Preview https://deploy-preview-10101--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/images.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918
Copy link
Copy Markdown
Member

Hi! Thank you for proposing this helpful addition!

Unfortunately we are not accepting any changes to the v4 version of our docs at the moment, since we are very close to releasing v5 docs and have stopped contributions to this branch and are preparing it for long-term, unmaintained mode.

Several pages are undergoing significant rewrites for version 5, and our entire structure and navigation system, so we are asking everyone to wait until we have published the stable v5 docs (which should be early December) to avoid conflicts and issues.

So, I will close this PR, but we would welcome this PR again next month, if you would still like to open one! I'm sorry that it's just bad timing here, and we do appreciate your contribution, even though we're not in a position to accept it at the moment! See you in v5, I hope! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants