Skip to content

feat(import): Remove ReadMore import from guides/deploy/deno.mdx cause usage got removed in #9949#10295

Merged
yanthomasdev merged 2 commits into
withastro:mainfrom
trueberryless:feat-remove-read-more-from-deno
Dec 8, 2024
Merged

feat(import): Remove ReadMore import from guides/deploy/deno.mdx cause usage got removed in #9949#10295
yanthomasdev merged 2 commits into
withastro:mainfrom
trueberryless:feat-remove-read-more-from-deno

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless commented Dec 8, 2024

Description (required)

Remove ReadMore import from guides/deploy/deno.mdx cause usage got removed in #9949

I'm not sure if it's really necessary. I guess that Astro builds the site without the import, idk...

Related issues & labels (optional)

@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 8, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b432bb8
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67558a7d82d4310008f455c6
😎 Deploy Preview https://deploy-preview-10295--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 8, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/deploy/deno.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

yanthomasdev
yanthomasdev approved these changes Dec 8, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch! 🙌

@yanthomasdev yanthomasdev merged commit ff6481d into withastro:main Dec 8, 2024
@trueberryless trueberryless deleted the feat-remove-read-more-from-deno branch December 8, 2024 12:45
trueberryless added a commit to trueberryless/withastro-docs that referenced this pull request Dec 8, 2024
@trueberryless
Update deno.mdx with withastro#10295
c2d5244
@trueberryless trueberryless mentioned this pull request Dec 8, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Dec 9, 2024
Merged
yanthomasdev added a commit that referenced this pull request Dec 16, 2024
@trueberryless @yanthomasdev
i18n(de): update guides/deploy/deno.mdx (#10294)
995b4e4 
* update deno

* changes from #5654

* Update deno.mdx with #10295

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@Nin3lee Nin3lee mentioned this pull request Dec 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@trueberryless @astrobot-houston @yanthomasdev