Skip to content

[I18nIgnore] fix(tutorial): remove a useless await in unit 5#10342

Merged
sarah11918 merged 1 commit into
withastro:mainfrom
ArmandPhilippot:fix/tutorial-useless-await
Dec 11, 2024
Merged

[I18nIgnore] fix(tutorial): remove a useless await in unit 5#10342
sarah11918 merged 1 commit into
withastro:mainfrom
ArmandPhilippot:fix/tutorial-useless-await

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot commented Dec 11, 2024

Description (required)

We have a remaining await in front of Object.values which is useless and makes the code snippets inconsistent across the tutorial, so I removed it.

Related issues & labels (optional)

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 11, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Dec 11, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 0b8bedb
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6759c29bf9aec90008eb7d72
😎 Deploy Preview https://deploy-preview-10342--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: I18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

File Note
en/tutorial/5-astro-api/1.mdx Source changed, localizations will be marked as outdated.
ko/tutorial/5-astro-api/1.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Dec 11, 2024
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear they're multiplying behind our backs!

@sarah11918 sarah11918 merged commit f8f35dd into withastro:main Dec 11, 2024
@ArmandPhilippot ArmandPhilippot deleted the fix/tutorial-useless-await branch December 11, 2024 17:55
thomasbnt added a commit that referenced this pull request Dec 11, 2024
* i18n(fr): update `tutorial/*`

See #9240, #10223, #10332 and #10342

* missing translation

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants