Skip to content

i18n(fr): Update guides/content-collection.mdx from #10688#10740

Merged
thomasbnt merged 19 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-guides-content-collections-01212025
Jan 21, 2025
Merged

i18n(fr): Update guides/content-collection.mdx from #10688#10740
thomasbnt merged 19 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-guides-content-collections-01212025

Conversation

@thomasbnt
Copy link
Copy Markdown
Member

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 21, 2025
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 21, 2025

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e7b7032
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/678fd69ca329b60007f62666
😎 Deploy Preview https://deploy-preview-10740--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jan 21, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
fr/guides/content-collections.mdx Localization changed, will be marked as complete.
fr/reference/content-loader-reference.mdx Localization changed, will be marked as complete.
fr/reference/modules/astro-content.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@thomasbnt
Copy link
Copy Markdown
Member Author

Note

Adding content-loader-reference to this PR..

@thomasbnt thomasbnt marked this pull request as draft January 21, 2025 14:23
…#10710

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt marked this pull request as ready for review January 21, 2025 14:50
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomasbnt! I just left a few suggestions about the wording and two titles that we should perhaps translate as well.

Comment thread src/content/docs/fr/reference/content-loader-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/content-loader-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/content-loader-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/content-loader-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/content-loader-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/content-loader-reference.mdx Outdated
Comment thread src/content/docs/fr/guides/content-collections.mdx Outdated
Comment thread src/content/docs/fr/guides/content-collections.mdx Outdated
thomasbnt and others added 9 commits January 21, 2025 16:36
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed that in my previous review: there another change in that file l225 (https://github.com/withastro/docs/pull/10710/files#diff-a4b088418618b66fd166198b8232044082d22a8ca665c1d3ac2c4ec5f55f69efR225). Loader API has been updated to Object loader API, I can't add a suggestion there.

Comment thread src/content/docs/fr/guides/content-collections.mdx Outdated
thomasbnt and others added 2 commits January 21, 2025 16:52
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
Copy link
Copy Markdown
Member Author

Sorry, I missed that in my previous review: there another change in that file l225 (#10710 (files)). Loader API has been updated to Object loader API, I can't add a suggestion there.

Just modified with 91b3790 (#10740), thanks again

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@thomasbnt thomasbnt merged commit 92ba828 into withastro:main Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants