fix(tutorial): prevent character encoding issue in unit 4#11159
Merged
Conversation
Contributor
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
approved these changes
Mar 5, 2025
Member
sarah11918
left a comment
There was a problem hiding this comment.
I hate that we need this 😅
Member
Author
|
Yeah, I know... at least it's one line, we don't need the whole page shell. 😅 |
ArmandPhilippot
added a commit
to ArmandPhilippot/astro-docs
that referenced
this pull request
Mar 6, 2025
thomasbnt
added a commit
that referenced
this pull request
Mar 6, 2025
See #11159 Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Since the change introduced by withastro/astro#12231 in Astro 5,
<meta charset="utf-8" />is no longer automatically added for Markdown files that use thelayoutfrontmatter property. So users was facing a character encoding issue in unit 4 while checking the rendering ofMarkdownPostLayoutbefore nesting it inBaseLayout.This PR:
<meta charset="utf-8" />in unit 4-2<meta charset="utf-8" />(I thought maybe it was easier for beginners to understand rather than removing it in step 1)Related issues & labels (optional)