Update Lunaria (Fixes Netlify deploy issue)#12066
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks Yan! 🙌🏽 I compared the dashboard with the live one, and I didn't notice anything broken. So, LGTM!
I'm just wondering if it's expected that the files "Translation status by file" table are no longer sorted alphabetically? Well, some of them are but not all (e.g. concepts is before basics).
Thanks @ArmandPhilippot, the files are now parallelized, so they aren't being sorted. Although they weren't initially "sorted", they respected the order of |
|
Oh okay, thanks for the explanation! It's not important from my point of view anyway (I rarely check the table to be honest, I find the list by language more helpful) but I preferred to be safe by reporting this. 😄 So, everything looks good to me! |
delucis
left a comment
There was a problem hiding this comment.
Thanks for digging into this @yanthomasdev! (And everyone else who helped investigate.)
We don’t have preview deploys for the i18n dashboard, but once you merge this, I’ll switch back to the new Netlify build image so we can confirm the fix is working for sure. (Although I think your test deployment is already very good evidence.)
|
@yanthomasdev Just checking in on this to see whether we need anything else for this one! Looks like you have the approvals to merge when ready! 🫡 |
|
Updated Netlify to the Noble build image and redeployed the Lunaria dashboard: https://app.netlify.com/projects/docs-i18n-dashboard-test/deploys/688389268828345398011401 Works perfectly — nice work 👏 Guess we should also make the same update in Starlight’s Lunaria set-up if anyone wants to make that PR! |
Description (required)
This updates the Lunaria prerelease to the latest version (we were a few versions behind). This means there are a few refactors, new small features, and fixes (including one for the Netlify deploy)
Here's a dashboard upload you can test with these changes:
https://test-lunaria-fix.netlify.app/
Note: there are quite a few status changes between this and our current dashboard, from my investigation these all seem to be correct and related to fixes in how Lunaria directives are detected/applied.
For example,
koandfrboth get a new outdated page from the 5.0 release PR, the@lunaria-track:directive didn't include localizations at all, so these files that had only link changes were marked as outdated in that PR and for some reason they weren't properly shown in the dashboard before.Related issues & labels (optional)