Skip to content

Update Lunaria (Fixes Netlify deploy issue)#12066

Merged
yanthomasdev merged 2 commits into
mainfrom
update-lunaria
Jul 25, 2025
Merged

Update Lunaria (Fixes Netlify deploy issue)#12066
yanthomasdev merged 2 commits into
mainfrom
update-lunaria

Conversation

@yanthomasdev
Copy link
Copy Markdown
Member

Description (required)

This updates the Lunaria prerelease to the latest version (we were a few versions behind). This means there are a few refactors, new small features, and fixes (including one for the Netlify deploy)

Here's a dashboard upload you can test with these changes:
https://test-lunaria-fix.netlify.app/

Note: there are quite a few status changes between this and our current dashboard, from my investigation these all seem to be correct and related to fixes in how Lunaria directives are detected/applied.

For example, ko and fr both get a new outdated page from the 5.0 release PR, the @lunaria-track: directive didn't include localizations at all, so these files that had only link changes were marked as outdated in that PR and for some reason they weren't properly shown in the dashboard before.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 23, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 67573e5
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68813ff348ecf5000868e60f
😎 Deploy Preview https://deploy-preview-12066--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Yan! 🙌🏽 I compared the dashboard with the live one, and I didn't notice anything broken. So, LGTM!

I'm just wondering if it's expected that the files "Translation status by file" table are no longer sorted alphabetically? Well, some of them are but not all (e.g. concepts is before basics).

@yanthomasdev
Copy link
Copy Markdown
Member Author

I'm just wondering if it's expected that the files "Translation status by file" table are no longer sorted alphabetically? Well, some of them are but not all (e.g. concepts is before basics).

Thanks @ArmandPhilippot, the files are now parallelized, so they aren't being sorted. Although they weren't initially "sorted", they respected the order of files in the configuration, and the files from each entry were then sorted. If people feel like that's important, we can add it back in the dashboard with a few lines.

@ArmandPhilippot
Copy link
Copy Markdown
Member

Oh okay, thanks for the explanation! It's not important from my point of view anyway (I rarely check the table to be honest, I find the list by language more helpful) but I preferred to be safe by reporting this. 😄 So, everything looks good to me!

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this @yanthomasdev! (And everyone else who helped investigate.)

We don’t have preview deploys for the i18n dashboard, but once you merge this, I’ll switch back to the new Netlify build image so we can confirm the fix is working for sure. (Although I think your test deployment is already very good evidence.)

@sarah11918
Copy link
Copy Markdown
Member

@yanthomasdev Just checking in on this to see whether we need anything else for this one! Looks like you have the approvals to merge when ready! 🫡

@yanthomasdev yanthomasdev merged commit 2fc733f into main Jul 25, 2025
10 checks passed
@yanthomasdev yanthomasdev deleted the update-lunaria branch July 25, 2025 13:28
@delucis
Copy link
Copy Markdown
Member

delucis commented Jul 25, 2025

Updated Netlify to the Noble build image and redeployed the Lunaria dashboard: https://app.netlify.com/projects/docs-i18n-dashboard-test/deploys/688389268828345398011401

Works perfectly — nice work 👏

Guess we should also make the same update in Starlight’s Lunaria set-up if anyone wants to make that PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants