Add instructions on date serialization at astro-actions.mdx#12082
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
sarah11918
left a comment
There was a problem hiding this comment.
Thank you for this helpful addition, @kaylaa0 ! It led to a discussion with our team because we realized that we hadn't made it very clear that this list is not really about what is supported, but what we've added special handling for. So in fact, our introduction of this list wasn't technically correct, and that's why something like z.coerce.date() wasn't included in the first place!
I've update the wording (sorry, there's no good way on GitHub for me to just make a suggestion to parts of the document that you didn't change, so I had to edit/update the file directly) to both use your example so people will get the idea, but also clarify what the list is.
What do you think about this?
|
Thank you for your in-depth explanation. I now have a better understanding of the issue. Your updates to the file are well worded and provide clear guidance for other developers as well. I think it looks great! |
sarah11918
left a comment
There was a problem hiding this comment.
Great! I'm glad this works for you and addresses your initial intention @kaylaa0 !
Thank you again for taking the time to contribute, leading to this helpful docs improvement, and welcome to Team Docs! 🥳
yanthomasdev
left a comment
There was a problem hiding this comment.
LGTM! Good job @kaylaa0, welcome to Team Docs!
Description
This PR adds documentation regarding date serialization in Astro actions, including an example for the following description:
Actions use
JSON.stringify()under the hood, which turns dates into their string representation. You can use z.coerce.date() instead.Including this new example will help guide developers when they encounter issues with date interpolation.
Related issues & labels (optional)
improve or update documentation