fix(configuration-reference): remove page slug from internal anchor links#12405
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thank you, Armand! OK, so as I see it what happened was:
So this PR would allow us to type I will let @delucis review this one when he returns! 😅 |
|
The formatting is broken, but after checking with "Edit": this is exactly that! 😅 |
|
Sarah, we need more yay!s:
(yay!)(yay!) |
delucis
left a comment
There was a problem hiding this comment.
Code change LGTM! Did you try running this locally just to double check it works @ArmandPhilippot?
|
@delucis Yes! I checked again and didn't spotted any unwanted changes or oversights! |
delucis
left a comment
There was a problem hiding this comment.
Perfect, then I approve! Thanks @ArmandPhilippot 🎉
Description (required)
Fixes the
docgenscript to remove/en/reference/configuration-reference/from internal anchor links.The changes was introduced by withastro/astro#14411 because relative links do not work in editors.
Now, instead of
[redirects](#redirects)we have[redirects](/en/reference/configuration-reference/#redirects)(for example).Both works, but maybe we should clean the links as we do to make them relative instead of absolute?
(I don't have a strong opinion on this, it just seemed weird while I was updating the French translation. So feel free to tell me to close this one 😄 )
Related issues & labels (optional)
site improvement?