docs: Update deutsch.md (i18n guide)#12500
Conversation
❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →
|
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
trueberryless
left a comment
There was a problem hiding this comment.
LGTM 🎉
If we find anything later, we can just PR again, so I think we can merge this 👍
randomguy-2650
left a comment
There was a problem hiding this comment.
I’ve left a few review comments based on a tutorial translation created by trueberryless (no double ping) according to #12501.
randomguy-2650
left a comment
There was a problem hiding this comment.
I have submitted lots of review comments, so the guide itself follows the rules of the guide.
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
randomguy-2650
left a comment
There was a problem hiding this comment.
I’ve made some changes to this guide. I don’t know why GitHub makes the line removal suggestions empty for suggestions on lines that weren’t changed, but whatever.
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
randomguy-2650
left a comment
There was a problem hiding this comment.
I just added tiny notes to this guide, after translating unit 6 of the Astro tutorial to German.
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
trueberryless
left a comment
There was a problem hiding this comment.
The new guide looks good to me 🪂
Left some final (never say final) suggestions and then I think we are good to go 📦
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
Co-authored-by: Felix Schneider <99918022+trueberryless@users.noreply.github.com>
randomguy-2650
left a comment
There was a problem hiding this comment.
I just added one little comment regarding about the uppercase Eszett (ẞ), but otherwise, LGTM!
Note (you may add this note yourself): I’ve tested on some operating systems and found out, that you can press AltGr + Shift + ß (next to zero) to input the uppercase Eszett (does work on Windows, not sure if it works in Linux distros).
Co-authored-by: randomguy-2650 <150704902+randomguy-2650@users.noreply.github.com>
randomguy-2650
left a comment
There was a problem hiding this comment.
Just one little thing, but it LGTM!
| - VSCode → VS Code | ||
| - NPM → npm | ||
| - Markennamen, deren Name sich im Laufe der Zeit geändert hat, werden mit dem aktuellen Namen genannt; der frühere Name steht in Klammern (z. B. X (Twitter)). | ||
| - Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol "U+00A0 NO-BREAK SPACE"](https://unicode-explorer.com/c/00A0) (` `) verwendet: |
There was a problem hiding this comment.
| - Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol "U+00A0 NO-BREAK SPACE"](https://unicode-explorer.com/c/00A0) (` `) verwendet: | |
| - Abkürzungen müssen in der gleichen Zeile stehen. Hierfür wird das [Unicode Symbol „U+00A0 NO-BREAK SPACE“](https://unicode-explorer.com/c/00A0) (` `) verwendet: |
Just this.
There was a problem hiding this comment.
I still think we should just tell people to use the HTML entity instead, or at least put it there as an option. CC @trueberryless thoughts?
There was a problem hiding this comment.
yeah, definitely mentioning at least or entirely replacing all...
trueberryless
left a comment
There was a problem hiding this comment.
Looks clean 🪥
After this PR is merged, we can look over #12523 and merge it as well 🙌
| - Markennamen, deren Name sich im Laufe der Zeit geändert hat, werden mit dem aktuellen Namen genannt; der frühere Name steht in Klammern (z. B. X (Twitter)). | ||
| - Verwendung der falschen Anführungszeichen ("" statt „“) | ||
| - Abkürzungen sind nicht mit non-breaking space versehen | ||
| - `z. B.` → `z. B.` (Unicode-Zeichen) oder `z. B.` (HTML-Entität) |
Description (required)
This PR updates the German i18n guide:
Related issues & labels (optional)
N/A