Skip to content

fix: use danger in astro db page and remove it in heroku page#13032

Merged
sarah11918 merged 3 commits into
withastro:mainfrom
KTibow:patch-1
Jan 14, 2026
Merged

fix: use danger in astro db page and remove it in heroku page#13032
sarah11918 merged 3 commits into
withastro:mainfrom
KTibow:patch-1

Conversation

@KTibow
Copy link
Copy Markdown
Contributor

@KTibow KTibow commented Jan 11, 2026

Description (required)

use the more severe danger instead of caution for a command that completely destroys the database

tested locally and danger was red while caution was yellow

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 11, 2026

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f218798
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6968169e7114a0000815c9e6
😎 Deploy Preview https://deploy-preview-13032--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jan 11, 2026

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/astro-db.mdx Source changed, localizations will be marked as outdated.
en/guides/deploy/heroku.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@ArmandPhilippot
Copy link
Copy Markdown
Member

Thanks for the contribution but I'm not sure this is needed... Can you explain why you think a danger aside would be more visible than a caution one?

If a caution is not enough, I doubt danger will be more useful. And, in Astro Docs, we usually use a caution for the "data loss" context, see: https://contribute.docs.astro.build/reference/custom-components/#aside-component.

@KTibow
Copy link
Copy Markdown
Contributor Author

KTibow commented Jan 12, 2026

It's true that caution is much more used, but danger is already used once (on the heroku page to warn about heroku-static-buildpack) and it feels more appropriate to use a red box ("dangerous") than a yellow one (warns you but not universally applicable). If the proper scope would need to look at all caution blocks then it's fair to close this PR (and possibly change that danger to a caution?)

@sarah11918
Copy link
Copy Markdown
Member

It's true that we rarely use the danger aside, mostly because there was nothing you could really do in Astro that really counts as that dangerous until we introduced Astro DB 😄

This would possibly be the only time I could see us using it. It is a pretty dangerous situation, so for this one time, I'm OK with it.

That Heroku guide should totally NOT be using a danger. That should be a note at best, as it's not really dangerous at all, but maybe a caution at least makes people pause before following the instructions. I could go either way with that. If you'd like to also downgrade the Heroku aside in this PR, I'd be happy to accept that, too!

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc. and removed improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) labels Jan 12, 2026
@KTibow KTibow changed the title fix: use danger instead of caution for destroying the database fix: use danger in astro db page and remove it in heroku page Jan 12, 2026
@sarah11918 sarah11918 merged commit 86a7eac into withastro:main Jan 14, 2026
10 checks passed
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jan 15, 2026
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consistency/formatting Standardizing without changing docs content e.g. indenting, lists etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants