Add RecipeLink component and link to recipes#3005
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
TheOtterlord
left a comment
TheOtterlord
left a comment
There was a problem hiding this comment.
Leaving my 2 cents here. Can't wait to have this component in the docs! The ownership on recipes is amazing
sarah11918
added
site improvement
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
|
Love you jumping in here, @TheOtterlord! @Jutanium, let's use this draft PR for adding recipe links to the other existing recipes, then consider this one good (even if it doesn't incorporate any design from Ximena yet.) We can make a separate PR to update the |
There was a problem hiding this comment.
Looking good @Jutanium ! I noticed that if there's only one recipe, then everything is all on one line in the component. I think I like that! One small point re: capitalization, but checking through, this all looks good!
Did you want to document using the recipe component in a separate PR?
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Thanks for building this out, Dan! Chef Houston is definitely a fun touch to be making an appearance in docs. Made a bunch of suggestions but mostly just cleaning up code and fixing bugs — love the idea in general 🙌
| title: Add an RSS feed | ||
| description: Let users subscribe to your content by adding an RSS feed to your Astro site. | ||
| i18nReady: true | ||
| type: recipe |
There was a problem hiding this comment.
Is this intentional? Didn’t see any discussion of why we’re making this not a recipe (which means it doesn’t show up in “More recipes”).
There was a problem hiding this comment.
Not intentional! Thanks so much for catching that
There was a problem hiding this comment.
Can we compress this? I’d drop it in https://squoosh.app/, make it 50% smaller (so it’s ~52px wide), and optimize it.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
4 participants
What kind of changes does this PR include?
Description