Fix the example code errors in the Endpoints section#3134
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
ElianCodes
approved these changes
May 1, 2023
Member
ElianCodes
left a comment
ElianCodes
left a comment
There was a problem hiding this comment.
I did not technically review this, but this would make sense!
olcchi
changed the title
delucis
approved these changes
May 2, 2023
Member
delucis
left a comment
delucis
left a comment
There was a problem hiding this comment.
Thanks @Ekarmore and for the review @ElianCodes!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
I found some issues in the example code in the params and Dynamic routing section while browsing through the documentation. The expected result mentioned in the documentation for the file path
src/pages/[id].json.tsand the routes generated by thegetStaticPaths()function is “This will generate three JSON endpoints at build time:/api/1.json, /api/2.json, /api/3.json.” However, the actual result generated by the example code is/0.json, /1.json, /2.json.So I modified the file path in the sample code in the document to
scr/pages/api/[id].json.ts, and changed the expected generated JSON endpoints in the document to the actual ones that will be produced, namely /api/0.json, /api/1.json, /api/2.json.I found that this part has the same issue in other language versions as well.