guides: update gitlab#5130
Merged
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
ElianCodes
approved these changes
Oct 18, 2023
Member
ElianCodes
left a comment
ElianCodes
left a comment
There was a problem hiding this comment.
Thanks for tackling this @dreyfus92!
sarah11918
added
the
improve or update documentation
Member
|
Thanks for this @dreyfus92 ! I'm adding the labels |
sarah11918
added
help - confirm behaviour
sarah11918
approved these changes
Nov 5, 2023
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
This looks really well written @dreyfus92 , and we haven't had anyone to check the new instructions, but we trust you as one of our top Team Docs members, so let's get this meeeeerged! 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
After trying to help a fellow member from Discord deploy their website with GitLab Pages, I conducted some research and found our documentation to be outdated. Therefore, I decided to improve the deployment guide to bring it up to date. Let me know what you guys think.
Related issues & labels (optional)