Skip to content

Fix incorrect endpoint return values in API Reference#5585

Merged
sarah11918 merged 3 commits into
withastro:mainfrom
mingjunlu:fix/return-values-in-api-reference
Dec 5, 2023
Merged

Fix incorrect endpoint return values in API Reference#5585
sarah11918 merged 3 commits into
withastro:mainfrom
mingjunlu:fix/return-values-in-api-reference

Conversation

@mingjunlu
Copy link
Copy Markdown
Contributor

Description

  • Some endpoint snippets in API Reference return plain objects
  • This PR changes those return values to Response objects

Related issues & labels

  • Suggested label: code snippet update

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 5, 2023 4:26pm

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. 4.0 merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Dec 4, 2023
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mingjunlu ! We will merge these tomorrow with all the other 4.0 docs! 🙌

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Dec 4, 2023
@sarah11918 sarah11918 merged commit 5f78584 into withastro:main Dec 5, 2023
@mingjunlu mingjunlu deleted the fix/return-values-in-api-reference branch December 6, 2023 04:14
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4.0 code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants