Skip to content

[i18nIgnore] Remove prettier pnpm note#7507

Merged
yanthomasdev merged 2 commits into
mainfrom
remove-prettier-pnpm
Mar 26, 2024
Merged

[i18nIgnore] Remove prettier pnpm note#7507
yanthomasdev merged 2 commits into
mainfrom
remove-prettier-pnpm

Conversation

@bluwy
Copy link
Copy Markdown
Member

@bluwy bluwy commented Mar 20, 2024

Description (required)

Since Prettier 3, I don't think prettier-plugin-astro should have issues with pnpm now. Original pnpm issue: prettier/prettier#8056

The current prettier setup recommendation works well for me.

I removed the caution block for all translations.

cc @Princesseuh

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@bluwy bluwy added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Mar 20, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 26, 2024 5:09pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Mar 26, 2024 5:09pm

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Mar 20, 2024
Copy link
Copy Markdown
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's correct! Prettier removed the auto plugin discovery completely, so it's no longer relevant. Good catch!

@yanthomasdev yanthomasdev changed the title [i18nignore] Remove prettier pnpm note [i18nIgnore] Remove prettier pnpm note Mar 26, 2024
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants