Skip to content

i18n(fr): Update guides/markdown-content.mdx from #9333#9370

Merged
yanthomasdev merged 72 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-guides-markdown-content
Sep 11, 2024
Merged

i18n(fr): Update guides/markdown-content.mdx from #9333#9370
yanthomasdev merged 72 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-guides-markdown-content

Conversation

@thomasbnt
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt commented Sep 9, 2024

Description (required)

Update guides/markdown-content.mdx from #9333

Note

At line 189, the link not working, this section was added in #9371 PR

Related issues & labels (optional)

  • Suggested label: i18n

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 9, 2024
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 9, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3129dc4
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66e1bb1408b6f80008c397ee
😎 Deploy Preview https://deploy-preview-9370--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Sep 9, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr guides/content-collections.mdx Localization changed, will be marked as complete.
fr guides/content.mdx Localization changed, will be marked as complete.
fr guides/markdown-content.mdx Localization changed, will be marked as complete.
fr guides/upgrade-to/v3.mdx Localization changed, will be marked as complete.
fr recipes/reading-time.mdx Localization changed, will be marked as complete.
fr reference/api-reference.mdx Localization changed, will be marked as complete.
fr reference/errors/invalid-frontmatter-injection-error.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
…ontent' into i18n-fr-update-guides-markdown-content
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a long one! First of all, well done, it wasn't easy to find your way around with the different sections that moved. But (yeah, sorry) I noticed some changes:

  • some typo
  • some link issue (I think there are still some)
  • at least one translation oversight
  • some reformulations that seemed easier to read with the previous version

And I added some optional suggestions to make it easier to read. So take your time to check everything. 😅

I may have forgotten some things... I will reread when this first pass is done! (not tonight, don't rush 😄 )

Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
thomasbnt and others added 21 commits September 9, 2024 23:34
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
thomasbnt and others added 6 commits September 10, 2024 23:28
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@thomasbnt thomasbnt force-pushed the i18n-fr-update-guides-markdown-content branch 2 times, most recently from f951998 to 24ac235 Compare September 11, 2024 12:12
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt thomasbnt force-pushed the i18n-fr-update-guides-markdown-content branch from 24ac235 to ab0b9c7 Compare September 11, 2024 12:16
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two last corrections and we should be good!

Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
thomasbnt and others added 3 commits September 11, 2024 14:38
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more link problems...

Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
thomasbnt and others added 2 commits September 11, 2024 14:51
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading this I don't see any more problems... let's hope it's the same with the Check links action! 😅

Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
thomasbnt and others added 2 commits September 11, 2024 15:04
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We dit it! 🎉 LGTM! 🚀

The broken links should be fixed with other PRs:

  • those related to basics/layout.mdx should be fixed with #9368
  • those related to guides/integrations-guide/mdx.mdx should be fixed with #9369
  • and the one related to guides/migrate-to-astro.mdx should be fixed with #9371

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spoke too soon... we have an issue with the page layout... (and I found another thing we could reformulate)

Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
thomasbnt and others added 2 commits September 11, 2024 15:39
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this time... LGTM! 🚀

I repeat myself so that it is visible >

The broken links should be fixed with other PRs:

  • those related to basics/layout.mdx should be fixed with #9368
  • those related to guides/integrations-guide/mdx.mdx should be fixed with #9369
  • and the one related to guides/migrate-to-astro.mdx should be fixed with #9371

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, LGTM! 🙌

@yanthomasdev yanthomasdev merged commit f7b27a3 into withastro:main Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants