Skip to content

i18n(fr): Update guides/markdown-content.mdx from #9888#9938

Merged
yanthomasdev merged 7 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-guides-markdown-content-06112024
Nov 6, 2024
Merged

i18n(fr): Update guides/markdown-content.mdx from #9888#9938
yanthomasdev merged 7 commits into
withastro:mainfrom
thomasbnt:i18n-fr-update-guides-markdown-content-06112024

Conversation

@thomasbnt
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt commented Nov 6, 2024

Description (required)

i18n(fr): Update guides/markdown-content.mdx from #9888

Note

Merge #9934 before this one. Links are broken.

Related issues & labels (optional)

  • Suggested label: i18n

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Nov 6, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 98ed9f7
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/672ba4c4a8e4540008c31011
😎 Deploy Preview https://deploy-preview-9938--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 6, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Nov 6, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr guides/markdown-content.mdx Localization changed, will be marked as complete.
fr guides/upgrade-to/v1.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some blank lines are missing which makes it a single block of text rather than multiple paragraphs.

Comment thread src/content/docs/fr/guides/markdown-content.mdx
Comment thread src/content/docs/fr/guides/markdown-content.mdx
Comment thread src/content/docs/fr/guides/markdown-content.mdx Outdated
thomasbnt and others added 3 commits November 6, 2024 15:49
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@thomasbnt
Copy link
Copy Markdown
Member Author

Some blank lines are missing which makes it a single block of text rather than multiple paragraphs.

Owh again.. thanks @ArmandPhilippot,I've had trouble since updating the comparison on GitHub. I'll have to see how I can see line breaks better.
JakePeraltaSquintingGIF

@ArmandPhilippot
Copy link
Copy Markdown
Member

@thomasbnt No problem! 😄

I was checking the broken links, it seems that upgrade-to/v1.mdx is not marked as outdated because it was partially updated... But we need an update around l333 to fix the link issue, see:

Can you add those changes to this PR?

As you noted the others are already corrected, so after that we'll be good! 🎉

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah well seen about the other line, I thought it was already up to date!

LGTM! 🚀

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@yanthomasdev yanthomasdev merged commit 2974841 into withastro:main Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants