From 36a58d786039bcc2a8d24fc886e19e2b797c0068 Mon Sep 17 00:00:00 2001 From: trueberryless Date: Mon, 14 Apr 2025 19:17:06 +0200 Subject: [PATCH 1/4] fix: Search modal translations --- src/starlightOverrides/Search.astro | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/src/starlightOverrides/Search.astro b/src/starlightOverrides/Search.astro index fea49881..947ca687 100644 --- a/src/starlightOverrides/Search.astro +++ b/src/starlightOverrides/Search.astro @@ -11,22 +11,32 @@ const docSearchStrings = .map(([key, value]) => [key.replace('docsearch.', ''), value]) // 4. Convert the long keys to nested objects (e.g. `modal.footer.closeText` => `modal: { footer: { closeText: "..." } }`) .reduce((dict, [key, val]) => { + const exceptions = ['button', 'shortcutLabel', 'placeholder']; const segments = key.split('.'); - let pointer = dict; + + if (exceptions.includes(key)) { + // Directly set at root level + dict[key] = val; + return dict; + } + + // Wrap everything else inside `modal` + let pointer = (dict.modal ??= {}); for (let i = 0; i < segments.length; i++) { const segment = segments[i]; if (i < segments.length - 1) { - // Build up the tree structure pointer[segment] ??= {}; pointer = pointer[segment]; } else { - // At the final node, set the leaf value. pointer[segment] = val; } } + return dict; - // biome-ignore lint/suspicious/noExplicitAny: + // biome-ignore lint/suspicious/noExplicitAny: }, {} as any); + +console.log(docSearchStrings) --- From eedd3ec29ad88c8f55d95e242a76b260c636c657 Mon Sep 17 00:00:00 2001 From: trueberryless Date: Mon, 14 Apr 2025 19:26:53 +0200 Subject: [PATCH 2/4] fix: remove console.log --- src/starlightOverrides/Search.astro | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/starlightOverrides/Search.astro b/src/starlightOverrides/Search.astro index 947ca687..ea4143f6 100644 --- a/src/starlightOverrides/Search.astro +++ b/src/starlightOverrides/Search.astro @@ -35,8 +35,6 @@ const docSearchStrings = return dict; // biome-ignore lint/suspicious/noExplicitAny: }, {} as any); - -console.log(docSearchStrings) --- From a0baf8df82ce01f16c8e83216ce4afccd0a8a4f2 Mon Sep 17 00:00:00 2001 From: trueberryless Date: Mon, 14 Apr 2025 19:31:12 +0200 Subject: [PATCH 3/4] feat: make changes minimal --- src/starlightOverrides/Search.astro | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/starlightOverrides/Search.astro b/src/starlightOverrides/Search.astro index ea4143f6..9c47e889 100644 --- a/src/starlightOverrides/Search.astro +++ b/src/starlightOverrides/Search.astro @@ -25,15 +25,16 @@ const docSearchStrings = for (let i = 0; i < segments.length; i++) { const segment = segments[i]; if (i < segments.length - 1) { + // Build up the tree structure pointer[segment] ??= {}; pointer = pointer[segment]; } else { + // At the final node, set the leaf value. pointer[segment] = val; } } - return dict; - // biome-ignore lint/suspicious/noExplicitAny: + // biome-ignore lint/suspicious/noExplicitAny: }, {} as any); --- From 6920ea1b301775a441a4f8cd3c2370d77b0029db Mon Sep 17 00:00:00 2001 From: trueberryless Date: Mon, 14 Apr 2025 19:31:39 +0200 Subject: [PATCH 4/4] fix: whitespace issues --- src/starlightOverrides/Search.astro | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/starlightOverrides/Search.astro b/src/starlightOverrides/Search.astro index 9c47e889..f232bba8 100644 --- a/src/starlightOverrides/Search.astro +++ b/src/starlightOverrides/Search.astro @@ -25,11 +25,11 @@ const docSearchStrings = for (let i = 0; i < segments.length; i++) { const segment = segments[i]; if (i < segments.length - 1) { - // Build up the tree structure + // Build up the tree structure pointer[segment] ??= {}; pointer = pointer[segment]; } else { - // At the final node, set the leaf value. + // At the final node, set the leaf value. pointer[segment] = val; } }