Posts & Pages: Refactor table handler #1#21874
Merged
kean merged 11 commits intotask/ui-modernization-posts-and-pagesfrom Oct 25, 2023
Merged
Posts & Pages: Refactor table handler #1#21874kean merged 11 commits intotask/ui-modernization-posts-and-pagesfrom
kean merged 11 commits intotask/ui-modernization-posts-and-pagesfrom
Conversation
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21874-c00b68b | |
| Version | 23.4 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | c00b68b | |
| App Center Build | WPiOS - One-Offs #7527 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr21874-c00b68b | |
| Version | 23.4 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | c00b68b | |
| App Center Build | jetpack-installable-builds #6554 |
momo-ozawa
approved these changes
Oct 25, 2023
|
|
||
| contentView.addSubview(mainStackView) | ||
| contentView.pinSubviewToAllEdges(mainStackView) | ||
| contentView.backgroundColor = .systemBackground |
Contributor
Contributor
Author
There was a problem hiding this comment.
The screen had a .grouped table view style, hence the different background color. Changing it to .plain.
Base automatically changed from
task/remove-dead-code-page-list-table-view
to
task/ui-modernization-posts-and-pages
October 25, 2023 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Some ground work:
Regression Notes
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: