diff --git a/CHANGELOG.md b/CHANGELOG.md index 07f5a5fe0..aabc22d51 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -14,7 +14,7 @@ _None_ ### Bug Fixes -_None_ +- Fix a bug in `create_release_backmerge_pull_request` when you pass a `intermediate_branch_created_callback` callback but there's ultimately nothing to merge. [#665] ### Internal Changes diff --git a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_backmerge_pull_request_action.rb b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_backmerge_pull_request_action.rb index 107fe3f07..bcba817dc 100644 --- a/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_backmerge_pull_request_action.rb +++ b/lib/fastlane/plugin/wpmreleasetoolkit/actions/common/create_release_backmerge_pull_request_action.rb @@ -124,6 +124,7 @@ def self.create_backmerge_pr(api_url:, token:, repository:, title:, head_branch: # When a callback was provided, do the pre-check about valid PR _only_ at that point, in case the callback added new commits unless can_merge?(intermediate_branch, into: base_branch) UI.error("Nothing to merge from #{intermediate_branch} into #{base_branch}. Skipping PR creation.") + Action.sh('git', 'checkout', head_branch) # Switch to original branch so we can delete the intermediate branch Fastlane::Helper::GitHelper.delete_local_branch_if_exists!(intermediate_branch) return nil end