From 62066bdbde99257e81960f0ef8978d865bf828d3 Mon Sep 17 00:00:00 2001 From: Dion Hulse Date: Tue, 22 Oct 2024 10:34:51 +1000 Subject: [PATCH 1/2] Don't check for missing files, current checksums don't offer that functionality. --- src/Checksum_Plugin_Command.php | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/Checksum_Plugin_Command.php b/src/Checksum_Plugin_Command.php index d35c82a6..3a0c7dbf 100644 --- a/src/Checksum_Plugin_Command.php +++ b/src/Checksum_Plugin_Command.php @@ -133,12 +133,6 @@ public function __invoke( $args, $assoc_args ) { $files = $this->get_plugin_files( $plugin->file ); - foreach ( $checksums as $file => $checksum_array ) { - if ( ! in_array( $file, $files, true ) ) { - $this->add_error( $plugin->name, $file, 'File is missing' ); - } - } - foreach ( $files as $file ) { if ( ! array_key_exists( $file, $checksums ) ) { $this->add_error( $plugin->name, $file, 'File was added' ); From dd2bbb6d927e42320604c43473e2ddc57f9ae05a Mon Sep 17 00:00:00 2001 From: Dion Hulse Date: Tue, 22 Oct 2024 10:36:04 +1000 Subject: [PATCH 2/2] Remove test --- features/checksum-plugin.feature | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/features/checksum-plugin.feature b/features/checksum-plugin.feature index d37b1aa0..0a32c366 100644 --- a/features/checksum-plugin.feature +++ b/features/checksum-plugin.feature @@ -20,17 +20,6 @@ Feature: Validate checksums for WordPress plugins """ And STDERR should be empty - When I try `wp plugin verify-checksums duplicate-post --format=json --version=3.2.2` - Then the return code should be 1 - And STDOUT should contain: - """ - "plugin_name":"duplicate-post","file":"duplicate-post-jetpack.php","message":"File is missing" - """ - And STDERR should be: - """ - Error: No plugins verified (1 failed). - """ - Scenario: Modified plugin doesn't verify Given a WP install @@ -50,19 +39,6 @@ Feature: Validate checksums for WordPress plugins Error: No plugins verified (1 failed). """ - When I run `rm wp-content/plugins/duplicate-post/duplicate-post.css` - Then STDERR should be empty - - When I try `wp plugin verify-checksums duplicate-post --format=json` - Then STDOUT should contain: - """ - "plugin_name":"duplicate-post","file":"duplicate-post.css","message":"File is missing" - """ - And STDERR should be: - """ - Error: No plugins verified (1 failed). - """ - When I run `touch wp-content/plugins/duplicate-post/additional-file.php` Then STDERR should be empty