Fix variable name mismatch in catch clause#53
Merged
Conversation
schlessera
requested changes
Apr 17, 2019
Member
|
Thanks for the PR, @randstring ! I would however fix this the other way around, with a clear variable name (not a single-letter abbreviation) in both places. |
Co-Authored-By: randstring <overripper@gmail.com>
Co-Authored-By: randstring <overripper@gmail.com>
Contributor
Author
|
You are right, a more descriptive name is certainly better. |
schlessera
approved these changes
Apr 17, 2019
schlessera
changed the title
Member
|
Thanks for the PR, @randstring ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was crashing the plugin for some specific WordPress instances. Fixing the exception variable name resolves the problem for me.