Implement CS checking based on the WP_CLI_CS ruleset#55
Merged
Conversation
Update .distignore and .gitignore with phpcs/phpunit config files Update wp-cli-tests to 2.1
Fix CS in find-command
schlessera
approved these changes
Jul 4, 2020
jrfnl
reviewed
Jul 4, 2020
| if ( ! $this->skip_ignored_paths ) { | ||
| // Assume base path doesn't need comparison | ||
| $compared_path = preg_replace( '#^' . preg_quote( $this->base_path ) . '#', '', $path ); | ||
| $compared_path = preg_replace( '#^' . preg_quote( $this->base_path, '/' ) . '#', '', $path ); |
There was a problem hiding this comment.
Uh.. oh... this is wrong... the delimiter should be passed as the second parameter and in this case, the delimiter is #.
Member
Author
There was a problem hiding this comment.
@schlessera, should I send a PR with # as the delimiter for preg_quote? I don't recall why I added /, not sure which is correct here.
Member
Member
There was a problem hiding this comment.
@thrijith Did you maybe intend to concatenate to add trailing slash here... ?
Member
There was a problem hiding this comment.
Either way, preg_quote() should have a # as the second argument in this case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a PHPCS ruleset using the new
WP_CLI_CSstandard.Fixes #54
Related wp-cli/wp-cli#5201