Windows detection fix#61
Closed
Vincent-HD wants to merge 3 commits into
Closed
Conversation
Member
|
@Vincent-HD Thanks for the pull request! Still happy with this? |
Member
|
@Vincent-HD Thanks again for your work on this! I created #67 so I could get the tests running on it. |
Author
|
No problem, happy to see it fixed :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #60
I tested the command on Linux and Windows, it's working as intended.
I removed all the '/' at the beginning of each ignored paths, it could be a good idea to add directory separator constant in the
stringposwhen testing if the path is supposed to be ignored, but it also means that if a user add a ignore path with a starting '/' it will be double without testing if present or not before.Note that the ending '/' does not matters on Windows, because windows also includes '/' at the end of paths for whatever reason