Cover read_geotiff_gpu/dask name= and read_geotiff_gpu max_pixels=#1627
Merged
Merged
Conversation
…args Test coverage gap sweep 2026-05-11 (pass 4) on the geotiff module. The prior pass closed the VRT backend coverage gaps; this pass closes the remaining MEDIUM Cat 4 (parameter coverage) gaps on the non-VRT GPU and dask read paths. Adds 12 tests covering: - read_geotiff_dask(name=...) -- direct, plus default-name-from-path. - read_geotiff_gpu(name=...) -- direct eager and dask+GPU paths, plus the default-name-from-path branch. - read_geotiff_gpu(max_pixels=...) -- accept and reject branches, plus the dask+GPU chunked reject branch. - open_geotiff(chunks=..., name=...), open_geotiff(gpu=True, name=...), open_geotiff(gpu=True, chunks=..., name=...) -- dispatch forwards name= through every backend branch. - open_geotiff(gpu=True, max_pixels=...) -- dispatch forwards max_pixels= into the GPU pipeline reject branch. All 12 tests pass on a CUDA host. GPU-only tests are guarded by the project's standard _gpu_only marker so non-GPU CI runs them as skip. No source changes; this is a test-only coverage sweep. State row updated in .claude/sweep-test-coverage-state.csv.
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds targeted test coverage for name= and max_pixels= kwarg plumbing through open_geotiff dispatch into the read_geotiff_dask and read_geotiff_gpu backends, focusing on previously uncovered GPU and dask+GPU branches in the non-VRT read paths.
Changes:
- Add a new geotiff test module covering
read_geotiff_dask(name=...),read_geotiff_gpu(name=...), andread_geotiff_gpu(max_pixels=...)accept/reject behavior (including dask+GPU). - Add dispatcher coverage ensuring
open_geotiff(..., name=...)forwards through chunks-only, gpu-only, and gpu+chunks branches, plusmax_pixelsrejection through the GPU branch. - Update the sweep tracking CSV state row for the geotiff module.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
xrspatial/geotiff/tests/test_kwarg_coverage_2026_05_11_r4.py |
Adds 12 tests covering name= and max_pixels= parameter-flow branches for dask, GPU, and dispatcher paths. |
.claude/sweep-test-coverage-state.csv |
Updates the geotiff sweep state entry to record pass 4 coverage work. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test coverage gap sweep 2026-05-11 (pass 4) on the geotiff module. Adds 12 tests covering MEDIUM Cat 4 (parameter coverage) gaps on the non-VRT GPU and dask read paths that pass 3 (#1620) did not reach.
read_geotiff_gpu(name=)direct, plus chunks+name (dask+GPU) and default-name-from-path branches.read_geotiff_dask(name=)direct, plus default-name-from-path branch.read_geotiff_gpu(max_pixels=)accept and reject branches, plus chunks+max_pixels reject (dask+GPU).open_geotiffdispatch coverage: forwardsname=through chunks-only, gpu-only, and gpu+chunks branches; forwardsmax_pixels=into the GPU pipeline reject branch.No source changes -- coverage-only.
Test plan
pytest xrspatial/geotiff/tests/test_kwarg_coverage_2026_05_11_r4.py)._gpu_onlymarker so non-GPU CI environments skip them..claude/sweep-test-coverage-state.csv.