From 47e99bfb26b59dca8725973fd00ba90a502870f2 Mon Sep 17 00:00:00 2001 From: Brendan Collins Date: Fri, 15 May 2026 08:37:26 -0700 Subject: [PATCH] geotiff: add max_cloud_bytes to canonical reader kwarg order (#1957) PR #1932 added the max_cloud_bytes kw-only param to open_geotiff but did not update _CANONICAL_ORDER in test_reader_kwarg_order_1935.py. The signature-parity test has been failing on main on every Python version ever since, blocking CI for every open PR. Insert max_cloud_bytes between max_pixels and on_gpu_failure to match the actual signature. The other readers (read_geotiff_dask, read_geotiff_gpu, read_vrt) don't expose this kwarg yet; the _assert_canonical helper intersects with the canonical tuple, so they keep passing. --- xrspatial/geotiff/tests/test_reader_kwarg_order_1935.py | 1 + 1 file changed, 1 insertion(+) diff --git a/xrspatial/geotiff/tests/test_reader_kwarg_order_1935.py b/xrspatial/geotiff/tests/test_reader_kwarg_order_1935.py index d099652c..17fd19d9 100644 --- a/xrspatial/geotiff/tests/test_reader_kwarg_order_1935.py +++ b/xrspatial/geotiff/tests/test_reader_kwarg_order_1935.py @@ -39,6 +39,7 @@ "chunks", "gpu", "max_pixels", + "max_cloud_bytes", "on_gpu_failure", "missing_sources", )