From b02da390d4a0f22c5c3ae5117ddd440f051eb40e Mon Sep 17 00:00:00 2001 From: Mario Rugiero Date: Wed, 16 Oct 2024 18:54:28 -0300 Subject: [PATCH 1/5] fix: add PR template, including acknowledgements reminder --- .github/pull_request_template.md | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 0000000000..f66eae29be --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,23 @@ +# TITLE + +## Description + +Description of the pull request changes and motivation. + +## Type of change + +Please delete options that are not relevant. + +- [ ] New feature +- [ ] Bug fix +- [ ] Optimization + +## Checklist +- [ ] Linked to Github Issue +- [ ] This change depends on code or research by an external entity + - [ ] Acknowledgements were updated to give credit +- [ ] Unit tests added +- [ ] This change requires new documentation. + - [ ] Documentation has been added/updated. +- [ ] This change is an Optimization + - [ ] Benchmarks added/run From b497d9770009b2acdf96267faa60c2a171ae29f9 Mon Sep 17 00:00:00 2001 From: Mario Rugiero Date: Wed, 16 Oct 2024 19:00:16 -0300 Subject: [PATCH 2/5] fix: acknowledge the giants we stand on --- README.md | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/README.md b/README.md index 2191e59f8a..099d6f5202 100644 --- a/README.md +++ b/README.md @@ -4,3 +4,19 @@ > To be used in testnet only. To learn more about Aligned and how to use it, refer to the [docs page](https://docs.alignedlayer.com/) or [docs folder](./docs/). + +# Acknowledgements + +Aligned wouldn't be possible without the valuable work of these people: +- [Ethereum](https://ethereum.org/en/), for being the network we all love +- [EigenLayer](https://www.eigenlayer.xyz) for providing restaking and AVS +- Shafi Goldwasser, Silvio Micali, and Charles Rackoff for [inventing ZK proofs](http://people.csail.mit.edu/silvio/Selected%20Scientific%20Papers/Proof%20Systems/The_Knowledge_Complexity_Of_Interactive_Proof_Systems.pdf) +- Eli Ben-Sasson and [Starkware](https://starkware.co) for making them practical +- [Consensys](https://consensys.io) for implementing the GROTH16 and PLONK protocols in [GNARK](https://docs.gnark.consensys.io) +- [RiscZero](https://risczero.com) for its namesake [proving system](https://github.com/risc0/risc0) +- [SuccintLabs](https://succinct.xyz) for creating [SP1](https://github.com/succinctlabs/sp1) +- [Paradigm](https://www.paradigm.xyz) for maintaining the [Ethers crate](https://crates.io/crates/ethers) +- [LambdaClass](https://lambdaclass.com) for writing [lambdaworks](https://github.com/lambdaclass/lambdaworks) + + +If you believe we missed someone, contact us! We're always happy to give credit where it's due. From 9ab437e78916a75cb32318457ebfb7c6309a5045 Mon Sep 17 00:00:00 2001 From: Mario Rugiero Date: Wed, 16 Oct 2024 19:27:24 -0300 Subject: [PATCH 3/5] fix: forgot about Foundry! --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 099d6f5202..38ef5fabf3 100644 --- a/README.md +++ b/README.md @@ -15,7 +15,7 @@ Aligned wouldn't be possible without the valuable work of these people: - [Consensys](https://consensys.io) for implementing the GROTH16 and PLONK protocols in [GNARK](https://docs.gnark.consensys.io) - [RiscZero](https://risczero.com) for its namesake [proving system](https://github.com/risc0/risc0) - [SuccintLabs](https://succinct.xyz) for creating [SP1](https://github.com/succinctlabs/sp1) -- [Paradigm](https://www.paradigm.xyz) for maintaining the [Ethers crate](https://crates.io/crates/ethers) +- [Paradigm](https://www.paradigm.xyz) for maintaining the [Ethers crate](https://crates.io/crates/ethers) and [Foundry](https://github.com/foundry-rs/foundry) - [LambdaClass](https://lambdaclass.com) for writing [lambdaworks](https://github.com/lambdaclass/lambdaworks) From 619418da9c1aa0d4ad91a783a87af962118c938f Mon Sep 17 00:00:00 2001 From: Uriel Mihura <43704209+uri-99@users.noreply.github.com> Date: Thu, 17 Oct 2024 17:19:59 -0300 Subject: [PATCH 4/5] Update .github/pull_request_template.md --- .github/pull_request_template.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index f66eae29be..a86454b32f 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,6 +11,7 @@ Please delete options that are not relevant. - [ ] New feature - [ ] Bug fix - [ ] Optimization +- [ ] Refactor ## Checklist - [ ] Linked to Github Issue From 187f77c2434396d9053b53e7d324eefeb7fecbc1 Mon Sep 17 00:00:00 2001 From: Uriel Mihura <43704209+uri-99@users.noreply.github.com> Date: Thu, 17 Oct 2024 20:01:50 -0300 Subject: [PATCH 5/5] Update .github/pull_request_template.md --- .github/pull_request_template.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a86454b32f..9ecda19125 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -22,3 +22,5 @@ Please delete options that are not relevant. - [ ] Documentation has been added/updated. - [ ] This change is an Optimization - [ ] Benchmarks added/run +- [ ] Has a known issue + - [Link to the open issue addressing it]()