Skip to content

execution bugfixes#3

Merged
gianbelinche merged 11 commits into
mainfrom
bug-fixes
Dec 11, 2025
Merged

execution bugfixes#3
gianbelinche merged 11 commits into
mainfrom
bug-fixes

Conversation

@fmoletta
Copy link
Copy Markdown
Contributor

@fmoletta fmoletta commented Dec 10, 2025

Fix the following bugs:

  • JALR: incorrect PC update (+offset should override usual +4)
  • Store/Load: used register address instead of value at register as base
  • JALR/JAL: if dst is zero, do not write next pc into it
  • MultipleOpcodes: Use i32 for immediate
  • Arithmetic operations with immediate: implement missing operations
  • SP: set starting sp value according to current size constraints

@fmoletta fmoletta marked this pull request as ready for review December 11, 2025 13:25
Comment thread vm/src/vm/instructions.rs Outdated
Comment thread vm/src/vm/instructions.rs Outdated
@gianbelinche gianbelinche merged commit 6c46ad9 into main Dec 11, 2025
2 checks passed
@JuArce JuArce deleted the bug-fixes branch December 11, 2025 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants