Skip to content

chore: dual-license under MIT OR Apache-2.0#612

Merged
MauroToscano merged 1 commit into
mainfrom
chore/dual-license
May 22, 2026
Merged

chore: dual-license under MIT OR Apache-2.0#612
MauroToscano merged 1 commit into
mainfrom
chore/dual-license

Conversation

@MauroToscano
Copy link
Copy Markdown
Contributor

Adopt the standard Rust dual-license layout:

  • Rename LICENSE to LICENSE-MIT
  • Add LICENSE-APACHE (Apache-2.0)
  • Set license = "MIT OR Apache-2.0" via [workspace.package] and inherit in every workspace crate
  • Add License + Contribution sections to README

@github-actions
Copy link
Copy Markdown

Codex Code Review

No issues found in the PR diff.

The changes are limited to licensing metadata/docs: adding workspace license = "MIT OR Apache-2.0", applying license.workspace = true to workspace crates, renaming LICENSE to LICENSE-MIT, and adding LICENSE-APACHE.

Validation:

  • git diff --check passed.
  • I attempted cargo metadata --no-deps, but the environment could not create a rustup temp file under /home/runner/.rustup/tmp due to a read-only filesystem, so manifest parsing was not independently verified here.

@claude
Copy link
Copy Markdown

claude Bot commented May 22, 2026

Review: chore/dual-license

Clean, well-structured PR. All 7 workspace crates correctly inherit license = "MIT OR Apache-2.0" from [workspace.package], using the canonical Rust dual-license setup.

No functional issues found. A couple of things worth confirming before merge:

Legal hygiene: If any external contributors have ever submitted code under the original MIT-only terms, they should explicitly agree to the relicensing before this merges. Apache 2.0 adds a patent grant (additive, not restrictive), but it's still a license change on their contribution. From the visible commit history this appears to be an internal team repo, so this is likely a non-issue.

Copyright year: Both license files use Copyright 2025 Yet Another Company. Perfectly fine if 2025 is the project inception year; if you want to reflect ongoing development, 2025-2026 is also conventional.

Everything else looks correct:

  • SPDX expression "MIT OR Apache-2.0" is correct Cargo syntax
  • license.workspace = true is the correct inheritance form, applied consistently to all 7 crates
  • LICENSE-APACHE is the unmodified canonical Apache 2.0 text
  • README license and contribution sections follow the standard Rust project template (e.g., rustc, tokio)

Adopt the standard Rust dual-license layout:
- Rename LICENSE to LICENSE-MIT
- Add LICENSE-APACHE (Apache-2.0)
- Set license = "MIT OR Apache-2.0" via [workspace.package]
  and inherit in every workspace crate
- Add License + Contribution sections to README
@MauroToscano MauroToscano merged commit 955186b into main May 22, 2026
17 checks passed
@MauroToscano MauroToscano deleted the chore/dual-license branch May 22, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants