From 65414f18599264a5f5e3c0e8f125386ea328605a Mon Sep 17 00:00:00 2001 From: John Kirkham Date: Mon, 10 Dec 2018 13:13:54 -0500 Subject: [PATCH 1/2] Drop temporary workaround for `get_codec` This workaround was added because `get_codec` was modifying its argument. However as of Numcodecs 0.6.0, `get_codec` does not modify its argument as it takes a copy and modifies the copy instead. Given as we now require Numcodecs 0.6.0, this workaround is no longer needed. Hence we drop it. --- zarr/core.py | 3 --- 1 file changed, 3 deletions(-) diff --git a/zarr/core.py b/zarr/core.py index b28f4e3419..80d1830c07 100644 --- a/zarr/core.py +++ b/zarr/core.py @@ -166,9 +166,6 @@ def _load_metadata_nosync(self): if config is None: self._compressor = None else: - # temporary workaround for - # https://github.com/zarr-developers/numcodecs/issues/78 - config = dict(config) self._compressor = get_codec(config) # setup filters From 1cde12f243f0bd2aebae4871e5ae9d9b4d1086c7 Mon Sep 17 00:00:00 2001 From: John Kirkham Date: Mon, 10 Dec 2018 13:17:50 -0500 Subject: [PATCH 2/2] Link this to the Numcodecs upgrade release note --- docs/release.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/release.rst b/docs/release.rst index e07a82cef7..e3c0b85d59 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -29,8 +29,8 @@ Bug fixes * The required version of the `numcodecs `_ package has been upgraded to 0.6.2, which has enabled some code simplification and fixes a failing test involving - msgpack encoding. By :user:`John Kirkham `, :issue:`360`, :issue:`352`, :issue:`355`, - :issue:`324`. + msgpack encoding. By :user:`John Kirkham `, :issue:`361`, :issue:`360`, :issue:`352`, + :issue:`355`, :issue:`324`. * Failing tests related to pickling/unpickling have been fixed. By :user:`Ryan Williams `, :issue:`273`, :issue:`308`.