From dd3c0d88b1676deae62583204e960accfbb61c6c Mon Sep 17 00:00:00 2001 From: Tanmay Date: Mon, 3 Feb 2025 15:36:59 -0500 Subject: [PATCH 1/6] register group module in MakeEncodingConfig --- app/encoding.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/app/encoding.go b/app/encoding.go index 1200d08043..a691122952 100644 --- a/app/encoding.go +++ b/app/encoding.go @@ -9,6 +9,7 @@ import ( banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" crisistypes "github.com/cosmos/cosmos-sdk/x/crisis/types" distrtypes "github.com/cosmos/cosmos-sdk/x/distribution/types" + groupmodule "github.com/cosmos/cosmos-sdk/x/group" slashingtypes "github.com/cosmos/cosmos-sdk/x/slashing/types" stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types" evmenc "github.com/zeta-chain/ethermint/encoding" @@ -48,6 +49,7 @@ func MakeEncodingConfig() ethermint.EncodingConfig { fungibletypes.RegisterInterfaces(registry) observertypes.RegisterInterfaces(registry) lightclienttypes.RegisterInterfaces(registry) + groupmodule.RegisterInterfaces(registry) return encodingConfig } From 77be2b1ba7f5ecda35496909cd01c1ce61aee091 Mon Sep 17 00:00:00 2001 From: Tanmay Date: Mon, 3 Feb 2025 15:50:01 -0500 Subject: [PATCH 2/6] fix comment --- app/encoding.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/encoding.go b/app/encoding.go index a691122952..853f3e412d 100644 --- a/app/encoding.go +++ b/app/encoding.go @@ -24,7 +24,7 @@ import ( observertypes "github.com/zeta-chain/node/x/observer/types" ) -// MakeEncodingConfig creates an EncodingConfig for testing +// MakeEncodingConfig creates an EncodingConfig func MakeEncodingConfig() ethermint.EncodingConfig { encodingConfig := evmenc.MakeConfig() registry := encodingConfig.InterfaceRegistry From 7df55307f2c88a344f56adcb18f9184253f779e7 Mon Sep 17 00:00:00 2001 From: Tanmay Date: Mon, 3 Feb 2025 16:03:29 -0500 Subject: [PATCH 3/6] add changelog --- app/encoding.go | 1 - changelog.md | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/app/encoding.go b/app/encoding.go index 853f3e412d..7a27dc6143 100644 --- a/app/encoding.go +++ b/app/encoding.go @@ -28,7 +28,6 @@ import ( func MakeEncodingConfig() ethermint.EncodingConfig { encodingConfig := evmenc.MakeConfig() registry := encodingConfig.InterfaceRegistry - // TODO test if we need to register these interfaces again as MakeConfig already registers them // https://github.com/zeta-chain/node/issues/3003 cryptocodec.RegisterInterfaces(registry) diff --git a/changelog.md b/changelog.md index 5db074482a..228d1c8957 100644 --- a/changelog.md +++ b/changelog.md @@ -34,6 +34,7 @@ ### Fixes * [3416](https://github.com/zeta-chain/node/pull/3416) - add a check for nil gas price in the CheckTxFee function +* [3460](https://github.com/zeta-chain/node/pull/3460) - add group module to the cosmos interface registry ## v26.0.0 From f367d12b2b379eb2bc3d3c837aa72dd8a82edc75 Mon Sep 17 00:00:00 2001 From: Tanmay Date: Mon, 3 Feb 2025 18:19:00 -0500 Subject: [PATCH 4/6] add interfaces for missing modules --- app/encoding.go | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/app/encoding.go b/app/encoding.go index 7a27dc6143..28bf386726 100644 --- a/app/encoding.go +++ b/app/encoding.go @@ -5,16 +5,22 @@ import ( upgradetypes "cosmossdk.io/x/upgrade/types" cryptocodec "github.com/cosmos/cosmos-sdk/crypto/codec" authtypes "github.com/cosmos/cosmos-sdk/x/auth/types" + vestingtypes "github.com/cosmos/cosmos-sdk/x/auth/vesting/types" "github.com/cosmos/cosmos-sdk/x/authz" banktypes "github.com/cosmos/cosmos-sdk/x/bank/types" + consensusparamtypes "github.com/cosmos/cosmos-sdk/x/consensus/types" crisistypes "github.com/cosmos/cosmos-sdk/x/crisis/types" distrtypes "github.com/cosmos/cosmos-sdk/x/distribution/types" + govtypesv1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1" + govtypesv1beta1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1" groupmodule "github.com/cosmos/cosmos-sdk/x/group" + proposaltypes "github.com/cosmos/cosmos-sdk/x/params/types/proposal" slashingtypes "github.com/cosmos/cosmos-sdk/x/slashing/types" stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types" evmenc "github.com/zeta-chain/ethermint/encoding" ethermint "github.com/zeta-chain/ethermint/types" evmtypes "github.com/zeta-chain/ethermint/x/evm/types" + feemarkettypes "github.com/zeta-chain/ethermint/x/feemarket/types" authoritytypes "github.com/zeta-chain/node/x/authority/types" crosschaintypes "github.com/zeta-chain/node/x/crosschain/types" @@ -49,6 +55,13 @@ func MakeEncodingConfig() ethermint.EncodingConfig { observertypes.RegisterInterfaces(registry) lightclienttypes.RegisterInterfaces(registry) groupmodule.RegisterInterfaces(registry) + govtypesv1beta1.RegisterInterfaces(registry) + govtypesv1.RegisterInterfaces(registry) + proposaltypes.RegisterInterfaces(registry) + crisistypes.RegisterInterfaces(registry) + feemarkettypes.RegisterInterfaces(registry) + consensusparamtypes.RegisterInterfaces(registry) + vestingtypes.RegisterInterfaces(registry) return encodingConfig } From 7c3ea5946a6234e11264cf90c50f5d3212b57492 Mon Sep 17 00:00:00 2001 From: Tanmay Date: Mon, 3 Feb 2025 18:50:24 -0500 Subject: [PATCH 5/6] add interfaces for missing modules --- changelog.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/changelog.md b/changelog.md index 228d1c8957..c8cd14aac7 100644 --- a/changelog.md +++ b/changelog.md @@ -34,7 +34,7 @@ ### Fixes * [3416](https://github.com/zeta-chain/node/pull/3416) - add a check for nil gas price in the CheckTxFee function -* [3460](https://github.com/zeta-chain/node/pull/3460) - add group module to the cosmos interface registry +* [3460](https://github.com/zeta-chain/node/pull/3460) - add missing module to the cosmos interface registry ## v26.0.0 From ea4bfa94b20b8a424997e05332e93432d254248a Mon Sep 17 00:00:00 2001 From: Tanmay Date: Mon, 3 Feb 2025 19:11:08 -0500 Subject: [PATCH 6/6] update changelog to v27.0.1 --- changelog.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/changelog.md b/changelog.md index c8cd14aac7..9682630a21 100644 --- a/changelog.md +++ b/changelog.md @@ -1,5 +1,11 @@ # CHANGELOG +## v27.0.1 + +### Fixes + +* [3460](https://github.com/zeta-chain/node/pull/3460) - add `group`,`gov`,`params`,`consensus`,`feemarket` ,`crisis`,`vesting` modules to the cosmos interface registry to enable parsing of tx results. + ## v27.0.0 ### Breaking Changes @@ -34,7 +40,6 @@ ### Fixes * [3416](https://github.com/zeta-chain/node/pull/3416) - add a check for nil gas price in the CheckTxFee function -* [3460](https://github.com/zeta-chain/node/pull/3460) - add missing module to the cosmos interface registry ## v26.0.0