Fix "unable to generate DLL import .lib file"#19319
Merged
Vexu merged 1 commit intoziglang:masterfrom Mar 16, 2024
Merged
Conversation
Closes ziglang#19284 As of 9f2cb92 configuring the global cache directory to a relative path causes errors of the following form when cross compiling to `windows-gnu`. ``` error: unable to generate DLL import .lib file for kernel32: FileNotFound ``` The issue occurred because the `def_final_path` included the global cache path as a prefix and later on the `def_final_file` was created using that path with the global cache directory handle.
Member
|
Nice, thanks for looking into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19284
As of 9f2cb92 configuring the global cache directory to a relative path causes errors of the following form when cross compiling to
windows-gnu.The issue occurred because the
def_final_pathincluded the global cache path as a prefix and later on thedef_final_filewas created using that path with the global cache directory handle.