Skip to content

Auto-index entryId on generated field tables #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kigiri merged 2 commits into from
May 4, 2026
+9 −1
Merged

Auto-index entryId on generated field tables #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6993183
feat(db): auto-index entryId on generated field tables
Mirak29 Apr 29, 2026
041b011
chore(deno.json): Bump dbversion
Mirak29 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion db/deno.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"@std/assert": "jsr:@std/assert@^1.0.19"
},
"name": "@01edu/db",
"version": "0.2.3",
"version": "0.2.4",
"license": "MIT",
"exports": {
".": "./mod.ts",
Expand Down
8 changes: 8 additions & 0 deletions db/entries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,14 @@ export const initEntries = <
[name]: { type },
})

// SQLite only auto-indexes primary keys. fieldId is the PK, so entryId
// needs an explicit index — without it any partial index on entryInternal
// triggers a full table scan of the field table on every join.
sql`
CREATE INDEX IF NOT EXISTS idx_${tableName}_entry_id
ON ${tableName}(entryId)
`.run()

fieldTables[name] = table
fields[name] = table
}
Expand Down