Skip to content

Conversation

@pmiess
Copy link
Contributor

@pmiess pmiess commented May 23, 2020

Add windows package of pngcrush.

This is a supported project with 142 packages across 91 repos on repology.

Add mingw64 pngcrush package
This depends on the mingw packages for gcc-libs #158 , zlib #159 , and png16 #160

pmiess added 2 commits May 23, 2020 16:41
This is a supported project with 142 packages across 91 repos on repology.

This is part of 0install/0install.de-feeds#3
This depends on the mingw packages for gcc-libs, zlib, and png16
@bastianeicher
Copy link
Member

bastianeicher commented May 24, 2020

There are official Windows binaries for pngcrush available that don't depend on mingw: https://sourceforge.net/projects/pmt/files/pngcrush-executables/

Perhaps it would be better to use these instead in the feed?

@pmiess
Copy link
Contributor Author

pmiess commented May 24, 2020

The official windows binaries are included in this feed.
They were updated January 2017
The Mingw project has released 2 updates to pngcrush,
8 updates to libpng and 3 updates zlib since then.
Do you want me to remove the mingw packages from this feed?

@bastianeicher
Copy link
Member

Ah sorry, I overlooked the Sourceforge archives already listed in the feed.

This is a bit of a tricky judgment call I suppose. According to the pngcrush changelog the updates in 1.8.12 and 1.8.13 don't seem to be too significant, but of course it's nicer if users get the latest version of an app when using a 0install feed. On the other hand a statically linked binary with no external dependencies can be downloaded faster and is less likely to break due to too many "moving pieces".

I think I lean slightly towards removing the MinGW packages so users get the same binaries that are linked to on the project's website.

@pmiess
Copy link
Contributor Author

pmiess commented May 24, 2020

It is done

@bastianeicher bastianeicher changed the title Add Pngcrush, A tool for optimizing the compression of PNG files Add Pngcrush May 24, 2020
@bastianeicher bastianeicher merged commit 173bc0f into 0install:master May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants