Skip to content

fix: don't convert regex from punycode to ASCII (#1126)#1131

Merged
0xERR0R merged 2 commits intomainfrom
fix-regex-parser
Sep 8, 2023
Merged

fix: don't convert regex from punycode to ASCII (#1126)#1131
0xERR0R merged 2 commits intomainfrom
fix-regex-parser

Conversation

@0xERR0R
Copy link
Copy Markdown
Owner

@0xERR0R 0xERR0R commented Sep 7, 2023

closes #1126

@0xERR0R 0xERR0R added the 🐞 bug Something isn't working label Sep 7, 2023
@0xERR0R 0xERR0R added this to the v0.23 milestone Sep 7, 2023
@0xERR0R 0xERR0R requested a review from ThinkChaos September 7, 2023 20:10
@kwitsch
Copy link
Copy Markdown
Collaborator

kwitsch commented Sep 8, 2023

The docker build failure should be fixed by running make fmt followed by a git commit & push.

@0xERR0R
Copy link
Copy Markdown
Owner Author

0xERR0R commented Sep 8, 2023

The docker build failure should be fixed by running make fmt followed by a git commit & push.

Thanks, I fixed it. 👍

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2023 •
edited
Loading

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
lists/parsers/hosts.go 100.00%

📢 Thoughts on this report? Let us know!.

ThinkChaos
ThinkChaos approved these changes Sep 8, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ThinkChaos ThinkChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this so fast!

@0xERR0R 0xERR0R merged commit 245bb61 into main Sep 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-regex-parser branch September 8, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThinkChaos ThinkChaos ThinkChaos approved these changes

@kwitsch kwitsch kwitsch approved these changes

Assignees

No one assigned

Labels

🐞 bug Something isn't working

Projects

None yet

Milestone

v0.23

Development

Successfully merging this pull request may close these issues.

Parse error domains containing xn--

3 participants

@0xERR0R @kwitsch @ThinkChaos