Conversation
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
ThinkChaos
reviewed
Sep 19, 2023
Collaborator
ThinkChaos
left a comment
ThinkChaos
left a comment
There was a problem hiding this comment.
Great idea, thanks for the implementation!
0xERR0R
force-pushed
the
bootrap-timeout
branch
from
b80d39b to
6275e31
Compare
ThinkChaos
approved these changes
Sep 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bootstrap uses default HttpTransport, which has (IMHO) no timeout defined. I think, it is a good idea to set a timeout.
I'm not so familiar with bootstrap logic, so pleas check it, maybe it is not correct?