Skip to content

fix: ANSI color codes being printed on Windows#1225

Merged
kwitsch merged 3 commits into0xERR0R:mainfrom
kwitsch:issues/1204
Nov 7, 2023
Merged

fix: ANSI color codes being printed on Windows#1225
kwitsch merged 3 commits into0xERR0R:mainfrom
kwitsch:issues/1204

Conversation

@kwitsch
Copy link
Copy Markdown
Collaborator

@kwitsch kwitsch commented Nov 7, 2023

Set logger output to colorable.NewColorableStdout for FormatTypeText to fix missing colors in Windows.

Closes: #1204

@kwitsch kwitsch added the 🐞 bug Something isn't working label Nov 7, 2023
@kwitsch kwitsch added this to the v0.23 milestone Nov 7, 2023
@kwitsch kwitsch requested a review from 0xERR0R November 7, 2023 19:07
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

📢 Thoughts on this report? Let us know!

@ThinkChaos ThinkChaos changed the title Issues/1204 fix: ANSI color codes being printed on Windows Nov 7, 2023
@kwitsch kwitsch merged commit d87e6b4 into 0xERR0R:main Nov 7, 2023
@kwitsch kwitsch deleted the issues/1204 branch November 7, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unresolved color codes in windows console - binary 0.22

2 participants