Skip to content

Refactoring/config struct names#1315

Merged
kwitsch merged 16 commits into0xERR0R:mainfrom
kwitsch:refactoring/config-names
Dec 20, 2023
Merged

Refactoring/config struct names#1315
kwitsch merged 16 commits into0xERR0R:mainfrom
kwitsch:refactoring/config-names

Conversation

@kwitsch
Copy link
Copy Markdown
Collaborator

@kwitsch kwitsch commented Dec 20, 2023

Changes:

@kwitsch kwitsch added the 🧰 technical debts Technical debts, refactoring label Dec 20, 2023
@kwitsch kwitsch enabled auto-merge (squash) December 20, 2023 18:01
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dece894) 93.83% compared to head (0c925b6) 93.83%.

❗ Current head 0c925b6 differs from pull request most recent head 546b136. Consider uploading reports for the commit 546b136 to get more accurate results

Files Patch % Lines
config/config.go 92.30% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1315   +/-   ##
=======================================
  Coverage   93.83%   93.83%           
=======================================
  Files          77       77           
  Lines        6200     6200           
=======================================
  Hits         5818     5818           
  Misses        293      293           
  Partials       89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@ThinkChaos ThinkChaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a couple leftovers hiding in comments

kwitsch and others added 3 commits December 20, 2023 21:37
Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
Co-authored-by: ThinkChaos <ThinkChaos@users.noreply.github.com>
@kwitsch kwitsch merged commit 03131c4 into 0xERR0R:main Dec 20, 2023
@kwitsch kwitsch deleted the refactoring/config-names branch December 20, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🧰 technical debts Technical debts, refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants