feat: configurable request read timeouts#1663
Merged
0xERR0R merged 6 commits into0xERR0R:mainfrom Dec 23, 2024
Merged
Conversation
This commit adds a request read timeout configuration parameter. As it is part of the downloading cycle, it is available under `blocking/loading/downloads`. The default value comes from `server/http.go` line 22. Refs: 0xERR0R#1653
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1663 +/- ##
==========================================
- Coverage 93.88% 93.83% -0.05%
==========================================
Files 78 80 +2
Lines 6361 6572 +211
==========================================
+ Hits 5972 6167 +195
- Misses 300 320 +20
+ Partials 89 85 -4 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #1653, this pull request introduces changes to the HTTP server configuration, adding a new configuration parameter for request read timeouts, updating the HTTP server initialization to use this new parameter, and adjusting the server creation logic accordingly.